Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes Necrotic Revival surgery from Abductors #9670

Merged

Conversation

Tyranicranger4
Copy link
Contributor

About The Pull Request

Gives Abductor Scientist's their own surgery granting trait, seperate from the normal debug SURGEON trait.
This trait - unlike the normal surgeon trait - grants all surgeries except for specifically excluded ones.

This then places necrotic revival onto that list.

What this means is that Abductors could still theoretically do necrotic revival - assuming they have an operating computer with it installed, but they no longer have it innately (which is what really matters). This was done mostly in case any other surgeries are added to the list in the future that they shouldn't have by default, but may be able to get access to through other means. Although, I'm entirely fine with changing it to where they can't do it at all if that's seen as the better option.

Why It's Good For The Game

Abductors aren't allowed to cause large scale destruction under our current policy; their toolkit reflects this, and that's unlikely to change given that it would go against the spirit of the role.
Abductors should not be able to perform necrotic revival surgery under normal circumstances, as the sole purpose of zombies is to cause large scale destruction.
Letting them keep it is confusing for players, annoying for administration, and feels borderline ban-baity.

Testing Photographs and Procedure

Screenshots&Videos

https://streamable.com/4rtsdg

Changelog

🆑
balance: Abductors no longer have access to necrotic revival surgery
code: Added TRAIT_ABDUCTOR_SURGEON, seperate from the normal SURGEON trait - to be used for Abductors.
/:cl:

Don't need this
@Rukofamicom
Copy link
Contributor

This was actually something I requested be done, though I don't remember who was present when I did.

Thank you for doing this the right way.

Copy link
Member

@EvilDragonfiend EvilDragonfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like using abductor_surgery_blacklist variable list check. It just should be early return when you have the trait and the surgery datum has the flag.
but also, this looks like it can return FALSE even if you're eligible to operate it with the operating computer.

@Tyranicranger4
Copy link
Contributor Author

Tyranicranger4 commented Aug 14, 2023

but also, this looks like it can return FALSE even if you're eligible to operate it with the operating computer.

I don't believe it can. The part I added will only return FALSE if the surgery is replaced by something else, which should happen. Otherwise it'll simply not return TRUE if it's in the blacklist, which still let's it go on to be checked for the normal requirements.
This was consistent with what happened when testing it (see testing evidence).

I'll look into the other changes in a bit.

Changes requested by Dragonfiend
Like this one better
Copy link
Member

@EvilDragonfiend EvilDragonfiend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's now good!

Requested change
Should do these too probably.
@PowerfulBacon PowerfulBacon added this pull request to the merge queue Aug 16, 2023
Merged via the queue into BeeStation:master with commit 63ecc0d Aug 16, 2023
@Tyranicranger4 Tyranicranger4 deleted the Necrotic-Revival-Nuh-Uh branch August 17, 2023 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants