Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abductors now have a smartfridge instead of their old fridge #9097

Merged
merged 8 commits into from
Aug 20, 2023

Conversation

EvilDragonfiend
Copy link
Member

@EvilDragonfiend EvilDragonfiend commented May 28, 2023

About The Pull Request

Abductors now have a smartfridge instead of their old fridge
That you don't know which container has which organ is one of reasons why abductors are usually annoying. They just put random shits into people.
This will let them have a choice of what they'll put into people.

Also, buffs gland generation amounts.

Why It's Good For The Game

removing tedious-ism.

Testing Photographs and Procedure

Screenshots&Videos

image

Changelog

🆑
tweak: abductor gland storage now uses smartfridge UI instead of too-alieny-UI.
balance: gland names will be revealed when these are in abductor's new organ storage.
tweak: abductor gland storage now has 2~7 glands per each at starting.
add: broken glands will be restored once you put these into a new storage (old one doesn't work)
/:cl:

@Tsar-Salat
Copy link
Contributor

Tsar-Salat commented May 28, 2023

This will let them have a choice of what they'll put into people.

Recommend putting balance in the changelog. It's going to have round ramifications.

@ghost
Copy link

ghost commented May 28, 2023

Recommend putting balance in the changelog. It's going to have round ramifications

The scientist can already see the organ names and pick the one they want, they just have to try every single slot. All this changes is removing the tediousness.

@EvilDragonfiend
Copy link
Member Author

Recommend putting balance in the changelog. It's going to have round ramifications

The scientist can already see the organ names and pick the one they want, they just have to try every single slot. All this changes is removing the tediousness.

At least agent can see names through this, but wouldn't be that matter, I think.

@EvilDragonfiend
Copy link
Member Author

actually I forgot to put that it in CL

Copy link
Member

@PowerfulBacon PowerfulBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lower the gland generation amounts so that you have to actually put different glands in people, make the fridge fit the abductor theme.

Is this a good change, should abductors be able to know easilly what they are putting in people?

@EvilDragonfiend
Copy link
Member Author

Lower the gland generation amounts so that you have to actually put different glands in people, make the fridge fit the abductor theme.

Is this a good change, should abductors be able to know easilly what they are putting in people?

Scientists can already identify what they're inserting. This PR removes the tediousness that player-side pressure to remember which container has which gland.
The only difference here is that an agent is now capable of identifying, but I think that's totally fine because a scientist will be there always.

@EvilDragonfiend
Copy link
Member Author

EvilDragonfiend commented May 31, 2023

change addressed.

image

gland amount is 2~7

@PowerfulBacon
Copy link
Member

Did you push?

@github-actions github-actions bot added the TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 label Jun 3, 2023
@EvilDragonfiend
Copy link
Member Author

Did you push?

I forgor 💀

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

EvilDragonfiend and others added 2 commits July 30, 2023 23:49
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
@EvilDragonfiend
Copy link
Member Author

addressed

@Crossedfall Crossedfall removed their request for review August 10, 2023 23:48
Copy link
Contributor

@PestoVerde322 PestoVerde322 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good to go, approved

@itsmeow itsmeow requested a review from PowerfulBacon August 18, 2023 04:49
@PowerfulBacon PowerfulBacon added this pull request to the merge queue Aug 20, 2023
Merged via the queue into BeeStation:master with commit 9580d2e Aug 20, 2023
@EvilDragonfiend EvilDragonfiend deleted the abus branch October 2, 2023 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance/Rebalance Feature Mapping DMM Change Sprites TGUI-Changes Contains changes to TGUI. Make sure its up to date with TGUI 4.0 Tools Tweak
Projects
Status: Not sorted
Development

Successfully merging this pull request may close these issues.

5 participants