Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrobbles submission should be delayed #256

Closed
Batwam opened this issue May 15, 2024 · 4 comments
Closed

Scrobbles submission should be delayed #256

Batwam opened this issue May 15, 2024 · 4 comments
Labels
implemented This feature/bug is implemented TestInBeta This feature can be tested in Beta

Comments

@Batwam
Copy link

Batwam commented May 15, 2024

Hello,

I noticed that Amperfy appears to submit Scrobbles to Last.fm pretty much as soon as the song start. This is a problem for me as it means that a song I skip after a few seconds (e.g. because I don't like it) still gets submitted and listed in my scrobbles.

As per Last.fm API:

A track should only be scrobbled when the following conditions have been met:

  • The track must be longer than 30 seconds.
  • And the track has been played for at least half its duration, or for 4 minutes (whichever occurs earlier.)

As soon as these conditions have been met, the scrobble request may be sent at any time. It is often most convenient to send a scrobble request when a track has finished playing.

Based on the above, Amperfy does not follow the methodology set up by last.fm.

Would it be possible to update the scrobble submission to either meet the definition or only submit once a song completes? Either of those would be better than the current method.

@BLeeEZ
Copy link
Owner

BLeeEZ commented May 15, 2024

I already reworked the scrobble behavior for 1.2.1. These criteria should be fulfilled and can be tested in the next beta.

@BLeeEZ BLeeEZ added the implemented This feature/bug is implemented label May 15, 2024
@Batwam
Copy link
Author

Batwam commented May 15, 2024

Amazing, I'm on the test flight version 1.2.0(3). Happy to test and confirm if needed.

Hopefully this update will get pushed soon?

@BLeeEZ BLeeEZ added the TestInBeta This feature can be tested in Beta label Jun 5, 2024
@BLeeEZ
Copy link
Owner

BLeeEZ commented Jun 5, 2024

This feature can be tested in the newest beta v1.2.1 (2): #25

@Batwam
Copy link
Author

Batwam commented Jun 11, 2024

I can confirm that amperfy now submits Now Playing upon song start and the scrobble

@BLeeEZ BLeeEZ closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implemented This feature/bug is implemented TestInBeta This feature can be tested in Beta
Projects
None yet
Development

No branches or pull requests

2 participants