Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear library cache without deleting downloaded songs #168

Closed
Bocom opened this issue Dec 23, 2022 · 5 comments
Closed

Clear library cache without deleting downloaded songs #168

Bocom opened this issue Dec 23, 2022 · 5 comments
Labels
enhancement New feature or request implemented This feature/bug is implemented TestInBeta This feature can be tested in Beta

Comments

@Bocom
Copy link

Bocom commented Dec 23, 2022

I used to have some broken tags in my Navidrome library (mojibake specifically) that have since been fixed, but the broken tags still show up in the library.

The artist that had broken tags just show empty lists, whereas the songs show up with the broken tags, but show the corrected tags while playing them.

I could delete the cache, but I would prefer to keep all the songs I have already downloaded, so it would be nice to get rid of these incorrect entries.

@sandersantema
Copy link
Contributor

Although I'm not the developer I'm fairly certain this isn't possible or at least not by changing something about Amperfy itself. Again since I'm not the developer take the rest of this comment with a grain of salt.

First of all, there is no difference between the library cache and the downloaded songs, I believe those are the same so there is no separate cache to delete only the songs themselves which also contain the tags.

Second, the subsonic api (or at least what's implemented by navidrome) doesn't seem to have a way to report what songs have changed metadata so Amperfy can't know.

Those two together make it so that the only solution here seems to be to delete all the songs with incorrect tags and download them again. If you know which songs these are you can create a playlist and delete/ download the whole playlist in one go.

@pjadeslandes
Copy link

I'm seeing this issue, and what I wonder may be a related issue where the app is caching more tracks than exist in the current library. This has happened following me updating tags of cached tracks.

Would the navidrome server support the following:

  • Scan the app cache to check that each track still exists in the server-based library, and delete the cached file from the app if not.
  • Scan the server-based library to see if the last-modified time of each server track is more recent than the cached time of each cached track, and then update the cached file to match the newer server file if applicable? I would understand if the mechanism involved simply deleting the file from the cache and downloading the new version again.

For me, Amperfy is far away the best mobile app experience of all the navidrome-compatible apps I've tried, which is all of them, including the ones you have to pay for. I particularly like the seamless full library cache functionality, but also the UX and UI is the nicest as far as I'm concerned. I can't say how grateful I am for its existence, so huge thank you from me for looking at this if you get the chance :)

@BLeeEZ
Copy link
Owner

BLeeEZ commented May 15, 2024

I reworked the caching system. Now (b7d81da) during a resync the already downloaded files (songs/podcast episodes/artworks) are reused. No need for downloading them again.

@BLeeEZ BLeeEZ added enhancement New feature or request implemented This feature/bug is implemented labels May 15, 2024
@BLeeEZ BLeeEZ added the TestInBeta This feature can be tested in Beta label Jun 5, 2024
@BLeeEZ
Copy link
Owner

BLeeEZ commented Jun 5, 2024

This feature can be tested in the newest beta v1.2.1 (2): #25

@BLeeEZ
Copy link
Owner

BLeeEZ commented Jun 15, 2024

Did you have time test the feature? Is it behaving as you expected?

@BLeeEZ BLeeEZ closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implemented This feature/bug is implemented TestInBeta This feature can be tested in Beta
Projects
None yet
Development

No branches or pull requests

4 participants