Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] SupporttTranscoded files #159

Closed
musiclandUSA opened this issue Sep 20, 2022 · 5 comments
Closed

[Feature] SupporttTranscoded files #159

musiclandUSA opened this issue Sep 20, 2022 · 5 comments
Labels
enhancement New feature or request implemented This feature/bug is implemented TestInBeta This feature can be tested in Beta

Comments

@musiclandUSA
Copy link

musiclandUSA commented Sep 20, 2022

Running the beta version of amperfy against the newest ampache (5.5.2 as of writing)

The app throws lots download errors, one for each song, all of them status code 1 file is empty.

I'm using AAC+ as the codec so I'm not sure if that is the cause, but it seemed to work fine with mp3 before I switched.

-movflags +faststart is set to be used.
encode_args_m4a = "-vn -c:a libfdk_aac -profile:a aac_he -vbr 3 -movflags +faststart -f adts pipe:1" is the ffmpeg command set

The only thing I can see from the logfile that might hint at an issue is this:

2022-09-20T11:55:17-04:00 [ampache] (/home/music/public_html/ampache/vendor/nyholm/psr7/src/MessageTrait.php:185) -> Header values must be RFC 7230 compatible strings.

2022-09-20T11:38:35-04:00 [ampache] (log.lib) -> [Runtime Error] Header may not contain NUL bytes in file /home/music/public_html/ampache/src/Module/Application/Playback/PlayAction.php(854)

The logfile for ampache shows successful encodes and files play fine through the web interface.

@BLeeEZ
Copy link
Owner

BLeeEZ commented Sep 22, 2022

Amperfy uses the URL provided in the XML response to download songs.

Could you please navigate to your songs download URL in your browser and check if it contains the correct file.
It seams the Ampache server API does not return the correct file.

Use this URL to get some song responses for a album id (filter value):
http://x.x.x.x/ampache/server/xml.server.php?action=album_songs&auth=xxxx&filter=14712

Example song URL which is used to download files:
https://x.x.x.x/play/index.php?ssid=xxxx&type=song&oid=115&uid=4&player=api&name=Chi.Otic%20-%20Are%20we%20going%20Crazy.wma

@musiclandUSA
Copy link
Author

musiclandUSA commented Sep 27, 2022

I tried generating an API key to put in auth= but all I get back is "session expired", I did pull these down by setting ampache to stream and pulling the playlist URLs inside:


https://servername.com/ampache/play/index.php?ssid=SSID&type=song&oid=10042&uid=2&name=Otis%20Redding%20-%20Mr.%20Pitiful.flac
https://servername.com/ampache/play/index.php?ssid=SSID&type=song&oid=603&uid=2&name=Andre%20Kostelanetz%20-%20It%20Came%20upon%20the%20Midnight%20Clear%20-%20Awayin%20a%20Manger.flac
https://servername.com/ampache/play/index.php?ssid=SSID&type=song&oid=10077&uid=2&name=William%20Bell%20-%20Everyday%20Will%20Be%20Like%20A%20Holiday.flac
https://servername.com/ampache/play/index.php?ssid=SSID&type=song&oid=11070&uid=2&name=Beatles%20-%20And%20I%20Love%20Her.flac
https://servername.com/ampache/play/index.php?ssid=SSID&type=song&oid=9379&uid=2&name=Stan%20Getz%20-%20Asturd%20Gilberto%20-%20The%20Girl%20From%20Ipanema%20-Unedited%20Stereo%20Remaster-.flac
https://servername.com/ampache/play/index.php?ssid=SSID&type=song&oid=10825&uid=2&name=Supremes-%20The%20-%20Stop-%20In%20The%20Name%20Of%20Love%20-Instrumental%20With%20BGV-.flac
https://servername.com/ampache/play/index.php?ssid=SSID&type=song&oid=9448&uid=2&name=Jimi%20Hendrix%20Experience-%20The%20-%20Red%20House.flac

@BLeeEZ
Copy link
Owner

BLeeEZ commented Apr 22, 2024

Transcoding is now implemented and supported.
Simulator Screenshot - iPhone 15 Pro Max - 2024-04-22 at 21 03 21

@BLeeEZ BLeeEZ added enhancement New feature or request implemented This feature/bug is implemented labels Apr 22, 2024
@BLeeEZ BLeeEZ changed the title [BUG] Transcoded files don't play most of the time [Feature] Transcoded files don't play most of the time Apr 22, 2024
@BLeeEZ BLeeEZ changed the title [Feature] Transcoded files don't play most of the time [Feature] SupporttTranscoded files Apr 22, 2024
@BLeeEZ BLeeEZ added the TestInBeta This feature can be tested in Beta label Jun 5, 2024
@BLeeEZ
Copy link
Owner

BLeeEZ commented Jun 5, 2024

This feature can be tested in the newest beta v1.2.1 (2): #25

@BLeeEZ
Copy link
Owner

BLeeEZ commented Jun 15, 2024

Did you have time test the feature? Is it behaving as you expected?

@BLeeEZ BLeeEZ closed this as completed Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request implemented This feature/bug is implemented TestInBeta This feature can be tested in Beta
Projects
None yet
Development

No branches or pull requests

2 participants