Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize Mixin: Early Returns #851

Open
ax3l opened this issue Feb 12, 2025 · 0 comments
Open

Optimize Mixin: Early Returns #851

ax3l opened this issue Feb 12, 2025 · 0 comments
Labels
component: elements Elements/external fields Performance optimization

Comments

@ax3l
Copy link
Member

ax3l commented Feb 12, 2025 •
edited
Loading

For the Alignment (and PipeAperture) mixing classes, we should add a default path (especially for shift_in/shift_out) that avoids calculations of default (zero) values.

In particular, the rotation sin|cos need to:

PipeAperture has this check already
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: elements Elements/external fields Performance optimization
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ax3l