From fb9f9fc702c2e5bb3c802c5e871553cb7d01b871 Mon Sep 17 00:00:00 2001 From: Thomas Edward Kingstone Date: Wed, 27 Mar 2024 16:29:13 +0000 Subject: [PATCH 1/2] fixed trailing comma on creating json data --- File_Adapter/CRUD/Create/CreateJson.cs | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/File_Adapter/CRUD/Create/CreateJson.cs b/File_Adapter/CRUD/Create/CreateJson.cs index 931e0e0..fc8e991 100644 --- a/File_Adapter/CRUD/Create/CreateJson.cs +++ b/File_Adapter/CRUD/Create/CreateJson.cs @@ -63,8 +63,9 @@ public FSFile CreateJson(FSFile file, PushType pushType, PushConfig pushConfig) bool valueTypesFound = false; - foreach (var obj in content) + for (int i = 0; i < content.Count; i++) { + object obj = content[i]; if (obj == null) continue; @@ -82,7 +83,10 @@ public FSFile CreateJson(FSFile file, PushType pushType, PushConfig pushConfig) continue; } - allLines.Add(obj.ToJson() + ","); + if (i != content.Count) + allLines.Add(obj.ToJson() + ","); + else + allLines.Add(obj.ToJson()); } if (valueTypesFound) From 8902786b5f5ac0151c7447eb7c1980cf0d7e5992 Mon Sep 17 00:00:00 2001 From: Thomas Edward Kingstone Date: Wed, 27 Mar 2024 16:42:56 +0000 Subject: [PATCH 2/2] better method --- File_Adapter/CRUD/Create/CreateJson.cs | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/File_Adapter/CRUD/Create/CreateJson.cs b/File_Adapter/CRUD/Create/CreateJson.cs index fc8e991..873e2fb 100644 --- a/File_Adapter/CRUD/Create/CreateJson.cs +++ b/File_Adapter/CRUD/Create/CreateJson.cs @@ -63,9 +63,8 @@ public FSFile CreateJson(FSFile file, PushType pushType, PushConfig pushConfig) bool valueTypesFound = false; - for (int i = 0; i < content.Count; i++) + foreach (var obj in content) { - object obj = content[i]; if (obj == null) continue; @@ -83,10 +82,7 @@ public FSFile CreateJson(FSFile file, PushType pushType, PushConfig pushConfig) continue; } - if (i != content.Count) - allLines.Add(obj.ToJson() + ","); - else - allLines.Add(obj.ToJson()); + allLines.Add(obj.ToJson()); } if (valueTypesFound)