Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make components always unsuppress event recordings at end of their run #485

Closed
IsakNaslundBh opened this issue Feb 27, 2024 · 2 comments · Fixed by #486
Closed

Make components always unsuppress event recordings at end of their run #485

IsakNaslundBh opened this issue Feb 27, 2024 · 2 comments · Fixed by #486
Assignees
Labels
type:feature New capability or enhancement

Comments

@IsakNaslundBh
Copy link
Contributor

Description:

Slight risk of the introduction of event suppression in BHoM/BHoM_Engine#3286 is that it is global, and if anything happens that means that the call to StopSuppressRecordingEvents is not reached for whatever reason (pre-mature return/exception/something else) that will mean that the warning system is supressed for all other components running in a script.

As a safety mechanism, we could add in a call to StopSuppressRecordingEvents as a final step to be called from the run method in the BHoM_UI to ensure that the warning system is always on for subsequent components.

@IsakNaslundBh IsakNaslundBh added the type:feature New capability or enhancement label Feb 27, 2024
@FraserGreenroyd
Copy link
Contributor

Welcome back to BHoM land @IsakNaslundBh - glad to see you're picking up on the changes we've made and already finding improvements 😄

@FraserGreenroyd
Copy link
Contributor

I would add the ThrowErrorsAsExceptions method to this as well and ensuring that resets to the default state as well (once BHoM/BHoM_Engine#3302 is merged).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants