Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geometry_Engine: Add HashArray method for core geometry types #3264

Closed
pawelbaran opened this issue Jan 25, 2024 · 2 comments · Fixed by #3268
Closed

Geometry_Engine: Add HashArray method for core geometry types #3264

pawelbaran opened this issue Jan 25, 2024 · 2 comments · Fixed by #3268
Assignees
Labels
type:feature New capability or enhancement

Comments

@pawelbaran
Copy link
Member

Description:

As in the title, HashArray seems to be missing for a few core geometry types:

  • TransformMatrix
  • Cartesian
@pawelbaran pawelbaran added the type:feature New capability or enhancement label Jan 25, 2024
@pawelbaran pawelbaran changed the title Geometry_Engine: Add HashArray method for TransformMatrix and Cartesian Geometry_Engine: Add HashArray method for core geometry types Jan 25, 2024
@alelom
Copy link
Member

alelom commented Jan 25, 2024

The reason why we didn't add GeometryHash for some geometric types is because we thought it would never get used with them. In particular, we added support for "non-conceptual" types: everything except Vector, TransformMatrix, Cartesian, and probably a few more. Anyways, it can make sense, for completion's sake, to add support for all -- especially now that we have added this new "aggregated" GeometryHash.

@pawelbaran
Copy link
Member Author

Yes, I see immediate use for transforms, so definitely worth adding 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants