Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialiser_Engine: Protect Bson not having an index #3168

Closed
FraserGreenroyd opened this issue Sep 4, 2023 · 0 comments · Fixed by #3169
Closed

Serialiser_Engine: Protect Bson not having an index #3168

FraserGreenroyd opened this issue Sep 4, 2023 · 0 comments · Fixed by #3169
Assignees
@FraserGreenroyd
Labels
type:bug Error or unexpected behaviour

Comments

@FraserGreenroyd
Copy link
Contributor

While testing BHoM/Versioning_Toolkit#231 locally with @albinber we found a TargetInvocation error being thrown https://github.com/BHoM/BHoM_Engine/blob/develop/Serialiser_Engine/Compute/Deserialise/List.cs#L88 here - where the bson object was an array according to bson, but had no elements so [0] was throwing an error.

Add a protection to that just in case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FraserGreenroyd FraserGreenroyd

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Serialiser_Engine: Protect against BSON having no values in list deserialisation BHoM/BHoM_Engine
1 participant
@FraserGreenroyd