Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Serialiser_Engine: Serialisation of decimals, doubles, and floats should be using only English representation #3130

Closed
adecler opened this issue Aug 3, 2023 · 0 comments · Fixed by #3134
Closed

Serialiser_Engine: Serialisation of decimals, doubles, and floats should be using only English representation #3130

adecler opened this issue Aug 3, 2023 · 0 comments · Fixed by #3134
Assignees
@adecler @FraserGreenroyd
Labels
type:bug Error or unexpected behaviour

Comments

@adecler
Copy link
Member

adecler commented Aug 3, 2023

Description:

Currently, Parse() and TryParse()` in the serialiser are culture dependent. This means that exchanging json data between a UK computer and a Dutch computer for example is likely causing the extraction of incorrect numbers.

For example, double.Parse("0.0045"); would give 45 in a Dutch computer.

GH seems to be set to English mode anyways but Chrome isn't so this impacts the zero-code tools.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adecler adecler

@FraserGreenroyd FraserGreenroyd

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Serialiser_Engine: Force invariant representation of number in serialisation BHoM/BHoM_Engine
2 participants
@adecler @FraserGreenroyd