Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Humans_Engine: Correct CValue output #2878

Closed
agneslindblom opened this issue Jul 4, 2022 · 0 comments · Fixed by #2879
Closed

Humans_Engine: Correct CValue output #2878

agneslindblom opened this issue Jul 4, 2022 · 0 comments · Fixed by #2879
Assignees
@agneslindblom
Labels
severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour

Comments

@agneslindblom
Copy link
Contributor

BHoM_Engine/Humans_Engine/Query/CvalueAnalysis.cs

Line 155 in bdde555

return new Cvalue(current.BHoM_Guid, "", 0, cvalue, horizDist, heightAbovePitch, absoluteDist, focal);

The change to this code means that using a default CValue does not work, because the variable being assigned to the result is the input cvalue rather than the calculated (via if statement) cValue - the variable we should use has a capital V in it but the one being used doesn't.

FYI @IsakNaslundBh
@agneslindblom agneslindblom added severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour labels Jul 4, 2022
@agneslindblom agneslindblom self-assigned this Jul 4, 2022
@agneslindblom agneslindblom mentioned this issue Jul 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agneslindblom agneslindblom

Labels
severity:critical No workaround exists. Essential to continue type:bug Error or unexpected behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Humans_Engine: Fix CValue variable use BHoM/BHoM_Engine
1 participant
@agneslindblom