Common_Engine: IElementCurves uses BHoMObject

[kThorsager]

Description:

IElement is not a BHoMObject. This still "works" as it's mostly used for Tex Bar & Panel which also is a BHoMObject.

The only thing this does is sending it to a decrepit method which then casts it to IElement to then call the new one. Hence simply changing BHoMObject to IElement would fix this.

BHoM_Engine/Common_Engine/Query/ElementCurves.cs

Line 86 in 9774432

foreach (BHoMObject element in elements)

[FraserGreenroyd]

I would agree that it would make logical sense when reading the code for the for loop to be
foreach(IElement element in elements)
than what is currently there. I see no reason why the for cannot be updated per the suggestion @kThorsager is making?

@IsakNaslundBh and @pawelbaran if you're in agreement I propose @kThorsager make the change for PR and review? 😄

[pawelbaran]

Yeah, this is legacy from the times when there was no IElement interface - should have been changed when the latter was being implemented. I believe the issue should be resolved while migrating all IElement-related stuff to Geometry_Engine.

[kThorsager]

Ok, then I'll add this in the TODO of #1316 whenever the Geometry_Engine .csproj is free

[pawelbaran]

@kThorsager is this still in progress or already resolved?

[kThorsager]

In progress in #1498
Was a bit distracted from all the planning around Geometry vs Common vs Spatial Engine