You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some modify methods, such as Transform, might not update the Guid of the object being changed. This is due to the fact that the method may not know if you are moving the objects, or essentially copying it like arraying a set of bars up along each story)
The Replace method added in #349 had the unintended side effect of culling duplicates based on BHoM_Guid - something that was not intended and should not happen.
Steps to reproduce:
Tranform the same for example Bar multiple times, and try to push them at the same time as any type of load. Only one (the first) of the arrayed bars will be pushed.
Expected behaviour:
For the replace objects to only try to replace if all objects being pushed have unique Ids. If any duplicate Id is found, the method should exit and not modify anything.
All objects being sent in to the method needs to be returned - no duplicate culling should be done!
Test file(s):
Have UT ready in the adapter test showcasing the issue.
The text was updated successfully, but these errors were encountered:
Description:
Some modify methods, such as Transform, might not update the Guid of the object being changed. This is due to the fact that the method may not know if you are moving the objects, or essentially copying it like arraying a set of bars up along each story)
The Replace method added in #349 had the unintended side effect of culling duplicates based on BHoM_Guid - something that was not intended and should not happen.
Steps to reproduce:
Tranform the same for example Bar multiple times, and try to push them at the same time as any type of load. Only one (the first) of the arrayed bars will be pushed.
Expected behaviour:
For the replace objects to only try to replace if all objects being pushed have unique Ids. If any duplicate Id is found, the method should exit and not modify anything.
All objects being sent in to the method needs to be returned - no duplicate culling should be done!
Test file(s):
Have UT ready in the adapter test showcasing the issue.
The text was updated successfully, but these errors were encountered: