Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency to BHoM_UI in the NuGet package for net standard 2.0 #73

Closed
adecler opened this issue Dec 17, 2023 · 2 comments · Fixed by BHoM/BHoM_UI#480, BHoM/BHoM#1598 or #77
Closed
Assignees
Labels
type:bug Error or unexpected behaviour

Comments

@adecler
Copy link
Member

adecler commented Dec 17, 2023

Description:

As per title. This causes a crash on ZCTs using the Analytics NuGet package without explicitly referencing the BHoM_UI package.
A good example of that is the BHoM API

Steps to reproduce:

Expected behaviour:

Test file(s):

@adecler adecler added the type:bug Error or unexpected behaviour label Dec 17, 2023
@FraserGreenroyd
Copy link

BHoM_UI is listed as a dependency on the latest Nuget:

image

And is listed as a dependency for this repo here (where the dependencies for the nuspec file are generated).

As such, I don't think there's any development actions for this repository as the dependency isn't missing at the Nuget level. I wonder if it's an issue caused by the ZCT not typically wanting .NetFramework472 references, which BHoM_UI currently targets?

@adecler
Copy link
Member Author

adecler commented Dec 18, 2023

The image above proves that BHoM_UI is not listed as a dependency for net standard 2.0.
ZCTs are working with .Net core 6 so they will not include dependencies targeting .Net framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
2 participants