Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add column value data type into the data-package-viewer #33

Open
ashepherd opened this issue Apr 12, 2023 · 4 comments
Open

Add column value data type into the data-package-viewer #33

ashepherd opened this issue Apr 12, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@ashepherd
Copy link
Collaborator

Screen Shot 2023-04-12 at 8 54 54 AM

Looks like it's default sorting all as strings.

From Laminar, I guess we could get this from infer types. Then, on the OSPREY side, we should be able to get this from the KG.

SELECT ?dataset ?parameter ?column_label ?frictionless_datatype ?definition ?scheme
WHERE {
  VALUES ?id { "887562"^^xsd:token }
  ?dataset odo:identifier [
    rdf:type odo:BCODMOIdentifier ;
    odo:identifierValue ?id
  ] .
  ?dataset a odo:Dataset .
  ?dataset odo:storesValuesFor ?parameter .
  ?parameter skos:prefLabel ?column_label .
  OPTIONAL { ?parameter odo:datatype [ odo:frictionlessdataDatatype ?frictionless_datatype ] }
  OPTIONAL { ?parameter skos:definition ?definition }
}
ORDER BY ?parameter

@adyork @whshannon

@ashepherd
Copy link
Collaborator Author

in the picture above the count column shows 80.03 wedged in between values of 8 and 9.

@cschloer
Copy link
Contributor

I think the best way to do this would be to update the submission tool code that grabs the laminar files such that it also grabs the schema from the laminar datapackage, and uses that schema in its own datapackage. That way when it's entered into the datapackage-viewer all of the necessary info is there (and we don't have to mess around with KG requests from the datapackage-viewer component).

@cschloer
Copy link
Contributor

And then we'll need to update the datapackage-viewer to make sure it's taking into account the schema. But that should be relatively easy.

@cschloer cschloer added the enhancement New feature or request label Apr 13, 2023
@cschloer
Copy link
Contributor

OK I've updated the submission tool such that from now on, new laminar files will get the schema from laminar. Assuming you're passing in these resource unedited to the datapackage-viewer @ashepherd , there shouldn't be any changes required on your end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants