Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AutoPR @azure/arm-consumption] Fix s360 error in Reservation Recommendations #6638

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 8 additions & 20 deletions sdk/consumption/arm-consumption/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,7 @@ const filter = "testfilter";
const skiptoken = "testskiptoken";
const top = 1;
const metric = "actualcost";
client.usageDetails.list(scope,{
expand: expand,
filter: filter,
skiptoken: skiptoken,
top: top,
metric: metric
}).then((result) => {
client.usageDetails.list(scope, expand, filter, skiptoken, top, metric).then((result) => {
console.log("The result is:");
console.log(result);
}).catch((err) => {
Expand Down Expand Up @@ -104,19 +98,13 @@ In browser applications, we recommend using the `InteractiveBrowserCredential` t
const skiptoken = "testskiptoken";
const top = 1;
const metric = "actualcost";
client.usageDetails.list(scope,{
expand: expand,
filter: filter,
skiptoken: skiptoken,
top: top,
metric: metric
}).then((result) => {
console.log("The result is:");
console.log(result);
}).catch((err) => {
console.log("An error occurred:");
console.error(err);
});
client.usageDetails.list(scope, expand, filter, skiptoken, top, metric).then((result) => {
console.log("The result is:");
console.log(result);
}).catch((err) => {
console.log("An error occurred:");
console.error(err);
});
</script>
</head>
<body></body>
Expand Down
2 changes: 1 addition & 1 deletion sdk/consumption/arm-consumption/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"rollup-plugin-sourcemaps": "^0.4.2",
"uglify-js": "^3.6.0"
},
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/feature/v4/sdk/consumption/arm-consumption",
"homepage": "https://github.com/Azure/azure-sdk-for-js/tree/master/sdk/consumption/arm-consumption",
"repository": {
"type": "git",
"url": "https://github.com/Azure/azure-sdk-for-js.git"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ class ConsumptionManagementClient extends ConsumptionManagementClientContext {
reservationRecommendationDetails: operations.ReservationRecommendationDetails;
reservationTransactions: operations.ReservationTransactions;
priceSheet: operations.PriceSheet;
forecasts: operations.Forecasts;
operations: operations.Operations;
aggregatedCost: operations.AggregatedCost;
events: operations.EventsOperations;
Expand Down Expand Up @@ -61,7 +60,6 @@ class ConsumptionManagementClient extends ConsumptionManagementClientContext {
this.reservationRecommendationDetails = new operations.ReservationRecommendationDetails(this);
this.reservationTransactions = new operations.ReservationTransactions(this);
this.priceSheet = new operations.PriceSheet(this);
this.forecasts = new operations.Forecasts(this);
this.operations = new operations.Operations(this);
this.aggregatedCost = new operations.AggregatedCost(this);
this.events = new operations.EventsOperations(this);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class ConsumptionManagementClientContext extends msRestAzure.AzureService

super(credentials, options);

this.apiVersion = '2019-10-01';
this.apiVersion = '2021-10-01';
this.acceptLanguage = 'en-US';
this.longRunningOperationRetryTimeout = 30;
this.baseUri = options.baseUri || this.baseUri || "https://management.azure.com";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ export {
ErrorDetails,
ErrorResponse,
EventSummary,
Forecast,
ForecastPropertiesConfidenceLevelsItem,
ForecastSpend,
LegacyChargeSummary,
LegacyReservationTransaction,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ export {
ErrorDetails,
ErrorResponse,
EventSummary,
Forecast,
ForecastPropertiesConfidenceLevelsItem,
ForecastSpend,
LegacyChargeSummary,
LegacyReservationTransaction,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ export {
ErrorDetails,
ErrorResponse,
EventSummary,
Forecast,
ForecastPropertiesConfidenceLevelsItem,
ForecastSpend,
LegacyChargeSummary,
LegacyReservationTransaction,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ export {
ErrorDetails,
ErrorResponse,
EventSummary,
Forecast,
ForecastPropertiesConfidenceLevelsItem,
ForecastSpend,
LegacyChargeSummary,
LegacyReservationTransaction,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,6 @@ export {
ErrorDetails,
ErrorResponse,
EventSummary,
Forecast,
ForecastPropertiesConfidenceLevelsItem,
ForecastSpend,
LegacyChargeSummary,
LegacyReservationTransaction,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ export {
ErrorResponse,
Events,
EventSummary,
Forecast,
ForecastPropertiesConfidenceLevelsItem,
ForecastSpend,
LegacyChargeSummary,
LegacyReservationTransaction,
Expand Down
62 changes: 0 additions & 62 deletions sdk/consumption/arm-consumption/src/models/forecastsMappers.ts

This file was deleted.

Loading