Skip to content

Commit

Permalink
Remove jstags that are redundant in a TS world (#8320)
Browse files Browse the repository at this point in the history
  • Loading branch information
ramya-rao-a authored Apr 14, 2020
1 parent 0d4018e commit 18f211d
Show file tree
Hide file tree
Showing 36 changed files with 0 additions and 122 deletions.
3 changes: 0 additions & 3 deletions sdk/core/core-amqp/src/ConnectionContextBase.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import { getPlatformInfo, getFrameworkInfo } from "./util/runtimeInfo";
import { isNode } from "./util/utils";

/**
* @interface ConnectionContextBase
* Provides contextual information like the underlying amqp connection, cbs session, tokenProvider,
* Connection config, data transformer, etc.
*/
Expand Down Expand Up @@ -67,7 +66,6 @@ export interface ConnectionContextBase {

/**
* Defines the properties that need to be set while establishing the AMQP connection.
* @interface ConnectionProperties
*/
export interface ConnectionProperties {
/**
Expand All @@ -88,7 +86,6 @@ export interface ConnectionProperties {

/**
* Describes the parameters that can be provided to create the base connection context.
* @interface CreateConnectionContextBaseParameters
*/
export interface CreateConnectionContextBaseParameters {
/**
Expand Down
1 change: 0 additions & 1 deletion sdk/core/core-amqp/src/auth/sas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ export class SharedKeyCredential {
}

/**
* @protected
* Creates the sas token based on the provided information
* @param {string | number} expiry - The time period in unix time after which the token will expire.
* @param {string} [audience] - The audience for which the token is desired.
Expand Down
3 changes: 0 additions & 3 deletions sdk/core/core-amqp/src/cbs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import { RequestResponseLink } from "./requestResponseLink";

/**
* Describes the CBS Response.
* @interface CbsResponse
*/
export interface CbsResponse {
correlationId: string;
Expand Down Expand Up @@ -59,7 +58,6 @@ export class CbsClient {

/**
* CBS sender, receiver on the same session.
* @private
*/
private _cbsSenderReceiverLink?: RequestResponseLink;

Expand Down Expand Up @@ -261,7 +259,6 @@ export class CbsClient {

/**
* Indicates whether the cbs sender receiver link is open or closed.
* @private
* @return {boolean} `true` open, `false` closed.
*/
private _isCbsSenderReceiverLinkOpen(): boolean {
Expand Down
2 changes: 0 additions & 2 deletions sdk/core/core-amqp/src/connectionConfig/connectionConfig.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { WebSocketImpl } from "rhea-promise";

/**
* Describes the options that can be provided while creating a connection config.
* @interface ConnectionConfigOptions
*/
export interface ConnectionConfigOptions {
/**
Expand All @@ -19,7 +18,6 @@ export interface ConnectionConfigOptions {
/**
* Describes the connection config object that is created after parsing an EventHub or ServiceBus
* connection string.
* @interface ConnectionConfig
*/
export interface ConnectionConfig {
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { ConnectionConfig } from "./connectionConfig";
* Describes the connection config object that is created after parsing an EventHub connection
* string. It also provides some convenience methods for getting the address and audience for
* different entities.
* @interface EventHubConnectionConfig
*/
export interface EventHubConnectionConfig extends ConnectionConfig {
/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { EventHubConnectionConfig } from "./eventhubConnectionConfig";
import { parseConnectionString, IotHubConnectionStringModel } from "../util/utils";

/**
* @interface IotHubConnectionConfig
* @ignore
*/
export interface IotHubConnectionConfig {
Expand Down
1 change: 0 additions & 1 deletion sdk/core/core-amqp/src/dataTransformer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { Buffer } from "buffer";
/**
* Describes the transformations that can be performed to encode/decode the data before sending it
* on (or receiving it from) the wire.
* @interface DataTransformer
*/
export interface DataTransformer {
/**
Expand Down
1 change: 0 additions & 1 deletion sdk/core/core-amqp/src/messageHeader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { logger } from "./log";

/**
* Describes the defined set of standard header properties of the message.
* @interface MessageHeader
*/
export interface MessageHeader {
/**
Expand Down
1 change: 0 additions & 1 deletion sdk/core/core-amqp/src/messageProperties.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { logger } from "./log";

/**
* Describes the defined set of standard properties of the message.
* @interface MessageProperties
*/
export interface MessageProperties {
/**
Expand Down
1 change: 0 additions & 1 deletion sdk/core/core-amqp/src/requestResponseLink.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import { logger, logErrorStackTrace } from "./log";

/**
* Describes the options that can be specified while sending a request.
* @interface SendRequestOptions
*/
export interface SendRequestOptions {
/**
Expand Down
1 change: 0 additions & 1 deletion sdk/core/core-amqp/src/retry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ export interface RetryOptions {

/**
* Describes the parameters that need to be configured for the retry operation.
* @interface RetryConfig
*/
export interface RetryConfig<T> {
/**
Expand Down
5 changes: 0 additions & 5 deletions sdk/core/core-amqp/src/util/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { WebSocketImpl } from "rhea-promise";
export { AsyncLock };
/**
* Describes the options that can be provided to create an async lock.
* @interface AsyncLockOptions
*/
export interface AsyncLockOptions {
/**
Expand Down Expand Up @@ -60,7 +59,6 @@ export const isNode =

/**
* Describes the servicebus connection string model.
* @interface ServiceBusConnectionStringModel
*/
export interface ServiceBusConnectionStringModel {
Endpoint: string;
Expand All @@ -72,7 +70,6 @@ export interface ServiceBusConnectionStringModel {

/**
* Describes the eventhub connection string model.
* @interface EventHubConnectionStringModel
*/
export interface EventHubConnectionStringModel {
Endpoint: string;
Expand All @@ -84,7 +81,6 @@ export interface EventHubConnectionStringModel {

/**
* Describes the stroage connection string model.
* @interface StorageConnectionStringModel
*/
export interface StorageConnectionStringModel {
DefaultEndpointsProtocol: string;
Expand All @@ -96,7 +92,6 @@ export interface StorageConnectionStringModel {

/**
* Describes the iothub connection string model.
* @interface IotHubConnectionStringModel
*/
export interface IotHubConnectionStringModel {
HostName: string;
Expand Down
1 change: 0 additions & 1 deletion sdk/eventhub/event-hubs/src/connectionContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ import { EventHubClientOptions } from "./models/public";
import { Dictionary, OnAmqpEvent, EventContext, ConnectionEvents } from "rhea-promise";

/**
* @interface ConnectionContext
* @internal
* @ignore
* Provides contextual information like the underlying amqp connection, cbs session, management session,
Expand Down
3 changes: 0 additions & 3 deletions sdk/eventhub/event-hubs/src/eventData.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import { Constants } from "@azure/core-amqp";

/**
* Describes the delivery annotations.
* @interface EventHubDeliveryAnnotations
* @ignore
*/
export interface EventHubDeliveryAnnotations extends DeliveryAnnotations {
Expand Down Expand Up @@ -34,7 +33,6 @@ export interface EventHubDeliveryAnnotations extends DeliveryAnnotations {

/**
* Map containing message attributes that will be held in the message header.
* @interface EventHubMessageAnnotations
* @ignore
*/
export interface EventHubMessageAnnotations extends MessageAnnotations {
Expand Down Expand Up @@ -62,7 +60,6 @@ export interface EventHubMessageAnnotations extends MessageAnnotations {

/**
* Describes the structure of an event to be sent or received from the EventHub.
* @interface
* @ignore
*/
export interface EventDataInternal {
Expand Down
11 changes: 0 additions & 11 deletions sdk/eventhub/event-hubs/src/eventHubReceiver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@ interface CreateReceiverOptions {
/**
* A set of information about the last enqueued event of a partition, as observed by the consumer as
* events are received from the Event Hubs service
* @interface LastEnqueuedEventProperties
*/
export interface LastEnqueuedEventProperties {
/**
Expand Down Expand Up @@ -110,52 +109,42 @@ export class EventHubReceiver extends LinkEntity {
options: EventHubConsumerOptions;
/**
* @property [_receiver] The RHEA AMQP-based receiver link.
* @private
*/
private _receiver?: Receiver;
/**
* @property _onMessage The message handler provided by the batching or streaming flavors of receive operations on the `EventHubConsumer`
* @private
*/
private _onMessage?: OnMessage;
/**
* @property _OnError The error handler provided by the batching or streaming flavors of receive operations on the `EventHubConsumer`
* @private
*/
private _onError?: OnError;
/**
* @property _onAbort The abort handler provided by the batching or streaming flavors of receive operations on the `EventHubConsumer`
* @private
*/
private _onAbort?: OnAbort;
/**
* @property _abortSignal An implementation of the `AbortSignalLike` interface to signal cancelling a receiver operation.
* @private
*/
private _abortSignal?: AbortSignalLike;
/**
* @property _checkpoint The sequence number of the most recently received AMQP message.
* @private
*/
private _checkpoint: number = -1;
/**
* @property _internalQueue A queue of events that were received from the AMQP link but not consumed externally by `EventHubConsumer`
* @private
*/
private _internalQueue: ReceivedEventData[] = [];
/**
* @property _usingInternalQueue Indicates that events in the internal queue are being processed to be consumed by `EventHubConsumer`
* @private
*/
private _usingInternalQueue: boolean = false;
/**
* @property _isReceivingMessages Indicates if messages are being received from this receiver.
* @private
*/
private _isReceivingMessages: boolean = false;
/**
* @property _isStreaming Indicated if messages are being received in streaming mode.
* @private
*/
private _isStreaming: boolean = false;

Expand Down
3 changes: 0 additions & 3 deletions sdk/eventhub/event-hubs/src/eventHubSender.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,18 +60,15 @@ export class EventHubSender extends LinkEntity {
/**
* @property _onSessionError The message handler that will be set as the handler on
* the underlying rhea sender's session for the "session_error" event.
* @private
*/
private _onSessionError: OnAmqpEvent;
/**
* @property _onSessionClose The message handler that will be set as the handler on
* the underlying rhea sender's session for the "session_close" event.
* @private
*/
private _onSessionClose: OnAmqpEvent;
/**
* @property [_sender] The AMQP sender link.
* @private
*/
private _sender?: AwaitableSender;

Expand Down
5 changes: 0 additions & 5 deletions sdk/eventhub/event-hubs/src/linkEntity.ts
Original file line number Diff line number Diff line change
Expand Up @@ -87,18 +87,15 @@ export class LinkEntity {
/**
* @property _context Provides relevant information about the amqp connection,
* cbs and $management sessions, token provider, sender and receivers.
* @protected
*/
protected _context: ConnectionContext;
/**
* @property _tokenRenewalTimer The token renewal timer that keeps track of when
* the Link Entity is due for token renewal.
* @protected
*/
protected _tokenRenewalTimer?: NodeJS.Timer;
/**
* @property _tokenTimeout Indicates token timeout in milliseconds
* @protected
*/
protected _tokenTimeoutInMs?: number;
/**
Expand All @@ -120,7 +117,6 @@ export class LinkEntity {
/**
* Negotiates cbs claim for the LinkEntity.
* @ignore
* @protected
* @param [setTokenRenewal] Set the token renewal timer. Default false.
* @returns Promise<void>
*/
Expand Down Expand Up @@ -191,7 +187,6 @@ export class LinkEntity {
/**
* Ensures that the token is renewed within the predefined renewal margin.
* @ignore
* @protected
* @returns
*/
protected async _ensureTokenRenewal(): Promise<void> {
Expand Down
4 changes: 0 additions & 4 deletions sdk/eventhub/event-hubs/src/managementClient.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ import { getRetryAttemptTimeoutInMs } from "./util/retries";
import { AbortSignalLike, AbortError } from "@azure/abort-controller";
/**
* Describes the runtime information of an Event Hub.
* @interface HubRuntimeInformation
*/
export interface EventHubProperties {
/**
Expand All @@ -49,7 +48,6 @@ export interface EventHubProperties {

/**
* Describes the runtime information of an EventHub Partition.
* @interface PartitionProperties
*/
export interface PartitionProperties {
/**
Expand Down Expand Up @@ -111,7 +109,6 @@ export class ManagementClient extends LinkEntity {
replyTo: string = uuid();
/**
* $management sender, receiver on the same session.
* @private
*/
private _mgmtReqResLink?: RequestResponseLink;

Expand Down Expand Up @@ -340,7 +337,6 @@ export class ManagementClient extends LinkEntity {
}

/**
* @private
* Helper method to make the management request
* @param request The AMQP message to send
* @param options The options to use when sending a request over a $management link
Expand Down
1 change: 0 additions & 1 deletion sdk/eventhub/event-hubs/src/models/public.ts
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ export enum CloseReason {
* }
* }
* ```
* @interface ClientOptions
*/
export interface EventHubClientOptions {
/**
Expand Down
1 change: 0 additions & 1 deletion sdk/eventhub/event-hubs/src/receiveHandler.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import { logger, logErrorStackTrace } from "./log";
export class ReceiveHandler {
/**
* @property _receiver The underlying EventHubReceiver.
* @private
*/
private _receiver: EventHubReceiver;

Expand Down
1 change: 0 additions & 1 deletion sdk/eventhub/event-hubs/src/receiver.ts
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ export class EventHubConsumer {
/**
* EventHubConsumer should not be constructed using `new EventHubConsumer()`
* Use the `createConsumer()` method on your `EventHubClient` instead.
* @private
* @constructor
* @internal
* @ignore
Expand Down
1 change: 0 additions & 1 deletion sdk/eventhub/event-hubs/src/sender.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ export class EventHubProducer {
/**
* EventHubProducer should not be constructed using `new EventHubProduer()`
* Use the `createProducer()` method on your `EventHubClient` instead.
* @private
* @constructor
* @internal
* @ignore
Expand Down
1 change: 0 additions & 1 deletion sdk/servicebus/service-bus/src/clientEntityContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { SessionManager } from "./session/sessionManager";
import { MessagingError } from "@azure/core-amqp";

/**
* @interface ClientEntityContext
* Provides contextual information like the underlying amqp connection, cbs session,
* management session, tokenCredential, senders, receivers, etc. about the ServiceBus client.
* @internal
Expand Down
1 change: 0 additions & 1 deletion sdk/servicebus/service-bus/src/connectionContext.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ import { OnAmqpEvent, EventContext, ConnectionEvents } from "rhea-promise";

/**
* @internal
* @interface ConnectionContext
* Provides contextual information like the underlying amqp connection, cbs session, management session,
* tokenCredential, senders, receivers, etc. about the ServiceBus client.
*/
Expand Down
Loading

0 comments on commit 18f211d

Please sign in to comment.