feat(cssc): 31231619 Enhance update command to check for Task yaml changes

[cegraybl]

This is a proposal to improve the experience when updating to a new version of the AZCLI extension.
This change modifies the behavior of the update command to silently check and update the Task definitions if there are any differences from the yamls defined on the extension.

This allows for users to move between versions and ensure that the task definition is always on the latest version, without requiring the user to delete and recreate the workflow, or for the hand holding to update the task definition on the customer's registry.

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

src/acrcssc/azext_acrcssc/helper/_deployment.py:118

• The word 'ust' should be corrected to 'us'.

# we need to know if tagging is something that will help ust,

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/acrcssc/azext_acrcssc/helper/_taskoperations.py:64

• The task_list parameter could potentially lead to unexpected behavior if reused across multiple calls. Consider ensuring that task_list is either reset or checked for duplication before appending tasks.

cssc_tasks_exists = check_continuous_task_exists(cmd, registry, task_list=task_list)

src/acrcssc/azext_acrcssc/_validators.py:82

• Ensure that the new behavior of check_continuous_task_exists with task_list is covered by tests.

def check_continuous_task_exists(cmd, registry, task_list=None):

src/acrcssc/azext_acrcssc/helper/_deployment.py:118

• The word 'ust' is misspelled. It should be 'us'.

# we need to know if tagging is something that will help ust,

[huanwu]

Other than checking the content, shall we also check if schedule_cron_expression is null? Either change should trigger a task update.

[cegraybl]

if the function gets schedule_cron_expression as None, it will retrieve the cron from the trigger task.
Do you mean that we should check if the returned task also has a null cron expression (i.e. the customer modified the task to remove the schedule?

[huanwu]

There're two scenarios where we should update the task, either when the task content (yaml) changes or schedul_cron_expression schedule is modified, right? If schedul_cron_expression is non, it means "No update", else it might means "update". So when to decide if to update the task, it should be based on 1. whether deployed_task is equal to extension_task 2. Whether schedule_cron_expression is null, e.g.

if deployed_task != extension_task or schedule_cron_expression is None:
...

In your current code, you only check if the task is equal or not. If it is not equal, you then check the schedule_cron_expression.

[cegraybl]

I see, the case when the deployed task and the extension task are the same and the schedule needs to be updated is on line 137 under _update_task_schedule.

This section is meant to handle only when the tasks are different, and if we don't have a cron expression (only the configuration is being updated) we need to retrieve it from the task to keep it the same, as the ARM template includes it as as parameter.

[Copilot]

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.