Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Pipeline failure - Expired PAT #5043

Closed
johnypony3 opened this issue Jan 2, 2025 · 6 comments · Fixed by #5054
Closed

[Bug] Pipeline failure - Expired PAT #5043

johnypony3 opened this issue Jan 2, 2025 · 6 comments · Fixed by #5054

Comments

@johnypony3
Copy link

johnypony3 commented Jan 2, 2025

Library version used

N/A

.NET version

N/A

Scenario

Other - please specify

Is this a new or an existing app?

None

Issue description and reproduction steps

This code is failing the pipeline, no deployments are happening.

        - name: Azure Pipelines Action
          uses: Azure/pipelines@354dddefceb0b503a61338ca81e4091eae3bc84f # v1
          with:
            azure-devops-project-url: https://identitydivision.visualstudio.com/IDDP
            azure-pipeline-name: 'MSAL.NET-OneBranch-Release-Official'
            azure-devops-token: ${{ secrets.AZURE_DEVOPS_TOKEN }}

Relevant code snippets

{
    "$id": "1",
    "customProperties": {
        "Descriptor": null,
        "IdentityDisplayName": null,
        "Token": null,
        "RequestedPermissions": 0,
        "NamespaceId": "00000000-0000-0000-0000-000000000000"
    },
    "innerException": null,
    "message": "Access Denied: The Personal Access Token used has expired.",
    "typeName": "Microsoft.VisualStudio.Services.Security.AccessCheckException, Microsoft.VisualStudio.Services.WebApi",
    "typeKey": "AccessCheckException",
    "errorCode": 0,
    "eventId": 3000
}

Expected behavior

The pipeline does not fail.

Identity provider

Microsoft Entra ID (Work and School accounts and Personal Microsoft accounts)

Regression

No response

Solution and workarounds

Generate new PAT and update value. Add monitoring to deployment.

@johnypony3 johnypony3 added needs attention Delete label after triage untriaged Do not delete. Needed for Automation labels Jan 2, 2025
@johnypony3 johnypony3 changed the title [Bug] Pipeline failure [Bug] Pipeline failure - Expired PAT Jan 2, 2025
@bgavrilMS
Copy link
Member

Not an MSAL issue.

@bgavrilMS bgavrilMS closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2025
@johnypony3
Copy link
Author

@bgavrilMS Respectfully you are closing bug tickets but the bug fixes are not being deployed because the pipeline is broken. As the owner of this repo, it would fall squarely on you to make sure this is deployed.

@bgavrilMS
Copy link
Member

bgavrilMS commented Jan 3, 2025

Hi @johnypony3 - this is an SDK. We publish a nuget package to https://www.nuget.org/ . Your application references our package explicitly and you manually point it to a version you are interested in.

In particular, the bug fix you want hasn't even been released. The GH milestone will show you which version of the SDK will have the fix (i.e. version 4.67.0)

That pipeline that you see failing is not the official pipeline. I can confirm that the bug fix has passed our pipeline, which is hosted on Azure DevOps.

@bgavrilMS bgavrilMS reopened this Jan 3, 2025
@bgavrilMS bgavrilMS added internal bug P2 and removed untriaged Do not delete. Needed for Automation needs attention Delete label after triage labels Jan 3, 2025
@bgavrilMS
Copy link
Member

Reopening to look at the GH Action failure

@johnypony3
Copy link
Author

Thank you for looking.

There is no milestone attached to the bug in question, or I am not sure how to look properly.

The last release of this package was 2 months ago, is this expected? I see many closed bugs, most of which do not have milestones attached. Which to me would indicate that these bug tickets should be open.

At the end of the day, this bug has been an issue for my team for over half a year. We are forced to deal with a security finding for this issue. I am looking for an eta on being able to update the package and close the finding.

Thank you for your time.

@bgavrilMS
Copy link
Member

Thanks @johnypony3 - I updated the milestone on the bug -
image

We aim to release MSAL 4.67.0 this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants