-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.3.0 #73
Merged
Merged
Release 0.3.0 #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge MSAL Extensions for Python 0.2.2 back to dev branch
Add CodeQL Analysis workflow
Move .github/workflows/workflows dir to .github/workflows
Handle file not found exceptions on Python 2.7
* Unified exception when load() is called before save() * Go with an explicit PersistenceNotFound exception * Caller has a much simpler pattern to handle read errors * Change "where" to "location" * Test cases for PersistentNotFound
Change PersistenceNotFound's base from OSError to IOError
Bumping version number
rayluo
approved these changes
Sep 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to add one more line in the release notes. Something like this (please proof-read):
- A non-exist persistence on Linux platform would previously return a
None
. Since this release, it will raisePersistenceNotFound
exception which becomes a consistent behavior on Windows and macOS.
Approving this release PR in advance.
Thanks @rayluo. Updating the release notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PersistenceNotFound
exception is now raised for cases where the persistence is not found. (Investigate OS errors returned for encryption scenarios on Windows and MacOS #64, Unified exception when load() is called before save() #67)None
. Since this release, it will raisePersistenceNotFound
exception which becomes a consistent behavior on Windows and macOS.