Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding new parameters to APIs for creating tokens results in parameter explosion #2993

Closed
msbw2 opened this issue Nov 9, 2024 · 0 comments · Fixed by #2991
Closed

Adding new parameters to APIs for creating tokens results in parameter explosion #2993

msbw2 opened this issue Nov 9, 2024 · 0 comments · Fixed by #2991
Assignees
@msbw2
Labels
Internal Indicates issue was opened by the IdentityModel team

Comments

@msbw2
Copy link
Contributor

msbw2 commented Nov 9, 2024

Any time a new parameter needs to be added to configure token creation various APIs need to be updated. These APIs have a lot of parameters already, and the SecurityTokenDescriptor class already exists to avoid this. Update all APIs so that internally they're using this class so that eventually the APIs with lots of parameters can be deprecated and removed.
@msbw2 msbw2 self-assigned this Nov 9, 2024
@msbw2 msbw2 linked a pull request Nov 9, 2024 that will close this issue
Use SecurityTokenDescriptor when creating tokens #2991
Merged
@keegan-caruso keegan-caruso added the Internal Indicates issue was opened by the IdentityModel team label Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@msbw2 msbw2

Labels
Internal Indicates issue was opened by the IdentityModel team
Projects
None yet
Milestone
No milestone
2 participants
@keegan-caruso @msbw2