Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diagnostic settings can end up with the same name #81

Closed
glennmusa opened this issue Mar 16, 2021 · 0 comments · Fixed by #82
Closed

diagnostic settings can end up with the same name #81

glennmusa opened this issue Mar 16, 2021 · 0 comments · Fixed by #82

Comments

@glennmusa
Copy link
Contributor

Benefit/Result/Outcome
When applying the saca-hub, the diagnostic settings that are created for the Firewall, PIP, NSG, and Virtual Network could end up in a situation where they share the same name but attmept to point to a different resource. This isn't feasible.

Instead, they should have unique names for the resource they point to.

Description
Add some uniqueness for the existing diagnostic settings in the repo

Acceptance Criteria

  • each diagnostic setting has a name unique for the resource it's pointing to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant