Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redeployment of update while running: workflow replacement fails #677

Open
D-r-P-3-p-p-3-r opened this issue Dec 16, 2024 · 1 comment
Open
Assignees

Comments

@D-r-P-3-p-p-3-r
Copy link

D-r-P-3-p-p-3-r commented Dec 16, 2024

Expected Behavior

The running update workflow should finish or should be successfully replaced by the new one.

Current Behavior

The redeployment leads to the termination of the running workflow, but the new one fails to start.

Steps to Reproduce

Redeploy an update while an installation is running on the device.

Device Information

  • Architecture: arm32
  • DU Agent Version: 1.1.0

Additional Information

During testing an update got redeployed while it was already running on a device.

The DUA log shows the following entry shortly after the redeployment:

2024-12-09T09:28:02.4290Z 992[992] [D] ComponentName:deviceUpdate, propertyName:service [ADUC_PnP_ComponentClient_PropertyUpdate_Callback:536]

It then apparently tried to replace the running update with the new one:

2024-12-09T09:28:03.9818Z 992[992] [I] Replacement. workflow '45a4bdac-648d-4754-809f-8783a978cce8' is being replaced with workflow 'bfe61d89-542f-4093-ba99-c5386233739c'. [ADUC_Workflow_HandlePropertyUpdate:511]
2024-12-09T09:28:03.9818Z 992[992] [I] Deferred Replacement workflow id [bfe61d89-542f-4093-ba99-c5386233739c] since current workflow id [45a4bdac-648d-4754-809f-8783a978cce8]
was still in progress. [ADUC_Workflow_HandlePropertyUpdate:526]
2024-12-09T09:28:03.9818Z 992[992] [D] cancellationType(2) => Replacement [ADUC_Workflow_HandleUpdateAction:628]
2024-12-09T09:28:03.9819Z 992[992] [I] Canceling request for in-progress operation. desiredAction: ProcessDeployment, cancellationType: Replacement [ADUC_Workflow_HandleUpdateAction:639]
2024-12-09T09:28:03.9819Z 992[992] [I] Requesting cancel for ongoing operation. [ADUC_Workflow_MethodCall_Cancel:1691]
2024-12-09T09:28:03.9819Z 992[992] [I] CancelCallback called [CancelCallback:320]

After the download step of the previous update was canceled successfully:

2024-12-09T09:29:10.0834Z 992[1017] [I] Action 'Download' complete. Result: -1 (succeeded), 0 (0x0) [ADUC_Workflow_WorkCompletionCallback:890]

But then something goes wrong with the replacement of the workflow:

2024-12-09T09:29:10.0837Z 992[1017] [W] Handling cancel completion, cancellation type 'Replacement'. [ADUC_Workflow_WorkCompletionCallback:937]
2024-12-09T09:29:10.0837Z 992[1017] [I] Starting process of deployment for 'Replacement' [ADUC_Workflow_WorkCompletionCallback:943]
2024-12-09T09:29:10.0838Z 992[1017] [D] Property '_workFolder' not NULL - returning cached workfolder '/.../45a4bdac-648d-4754-809f-8783a978cce8' [workflow_get_workfolder:1908]
2024-12-09T09:29:10.0838Z 992[1017] [I] Cleanup sandbox before replacement workflow [ADUC_Workflow_WorkCompletionCallback:959]
2024-12-09T09:29:10.0839Z 992[1017] [I] Destroying sandbox /.../45a4bdac-648d-4754-809f-8783a978cce8. workflowId: 45a4bdac-648d-4754-809f-8783a978cce8 [SandboxDestroy:404]
2024-12-09T09:29:10.4108Z 992[1017] [D] set prop '_workFolder' to '/.../bfe61d89-542f-4093-ba99-c5386233739c' [workflow_set_string_property:1683]
2024-12-09T09:29:10.4109Z 992[1017] [E] Invalid workflow step 1 -- ignoring [ADUC_Workflow_TransitionWorkflow:807]

@eshashah-msft
Copy link
Contributor

@D-r-P-3-p-p-3-r Thanks for reporting the issue. We will take a look at this and update here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants