Add custom environment variable options to pool configuration #253
Conversation
- Add the option to include custom environment variables in the pool configuration - This allows users to setup Batch environment variables for the start task - This in turn could allow for the ability to use batch insights
|
|
|
Apologies for the delay, can you add the env var spec to the pool schema for validation? |
- CHANGELOG updated with pool env var feature
|
Done - please let me know if you think anything else is required. Will a develop-cli docker image be built with the latest changes if they are merged in? Or will there be another release soon? |
|
|
- Added a keyvault option to the pool configuration - Updated docs, schemas and templates accordingly - Changed schema type from `str` to `text` for env vars
- Add a keyvault client check to ensure a valid client is used when using keyvault to add env vars to the start task.
|
I've made the (possibly final) minor change for this PR and have tested the changes manually to ensure that they do enable the use of batch insights, as specified in #252. Thanks for the support, and i'll keep an eye on the progress of the next iteration of this issue as discussed in the earlier comments. |
* Add env vars option to pool configuration - Add the option to include custom environment variables in the pool configuration - This allows users to setup Batch environment variables for the start task - This in turn could allow for the ability to use batch insights * Add env var spec to pool schema for validation - CHANGELOG updated with pool env var feature * Add a keyvault option for pool env vars - Added a keyvault option to the pool configuration - Updated docs, schemas and templates accordingly - Changed schema type from `str` to `text` for env vars * Add keyvault client check - Add a keyvault client check to ensure a valid client is used when using keyvault to add env vars to the start task.
Add the option to include custom environment variables in the pool configuration, see #252 for more information.
Pull Request Checklist
masterif it includes no features (open againstdevelopotherwise)Description
This is a possible start on how to solve #252, however this may be the wrong approach. Any feedback is welcome.