Add default packages to mlflow environment #3863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results for assets-test1 tests 0 ✅ 5m 27s ⏱️ For more details on these failures, see this check. Results for commit 98782ba. ♻️ This comment has been updated with latest results. |
vizhur
requested changes
Feb 25, 2025
| @@ -21,6 +21,8 @@ COPY mlflow_hf_score_cpu.py /var/mlflow_resources/mlflow_hf_score_cpu.py | |||
| COPY mlflow_hf_score_gpu.py /var/mlflow_resources/mlflow_hf_score_gpu.py | |||
|
|
|||
| # Create conda environment | |||
| # Add default packages | |||
| RUN conda config --add create_default_packages azureml-inference-server-http --add create_default_packages azureml-ai-monitoring --add create_default_packages azureml-contrib-services | |||
There was a problem hiding this comment.
This is so wrong...
- The intent of curated environment images is to use them as is. You should not expect anyone building on top of it. Customers do that, but that is their problem. For those scenarios we have base images. So, if you need those packages, pin them properly and move them to conda spec.
- Contrib-services is a joke no a package. Whatever you need to do you can ship with inference server. Contrib packages by design are not allowed in any prod scenarios. Saying that as the author of contrib packages concept in AzureML
- azureml-ai-monitoring besides the name of the package, there are many questions. Like where is the source. Why it is not maintainer. At all. you are installing it in py312 but classifiers say it only supports up to py310. This "Create environment with base image
mcr.microsoft.com/azureml/openmpi4.1.0-ubuntu20.04and conda dependencies, then build the environment.\n\n```\nchannels:\n - conda-forge\ndependencies:\n - python=3.8\n - pip=22.3.1\n - pip:\n - azureml-defaults==1.38.0\n - azureml-ai-monitoring\nname: model-env" in the description of the package says hard no to any reference to this package. from deprecated base image, eol interpreter version, pip that is vulnerable, to 3+ years old version of azureml-defaults that brings a ton outdated and incompatible packages.
contrib-services is a joke package. None of the prod scenarios should depend on contrib, by design.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.