Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging output of aso-gen #2853

Closed
theunrepentantgeek opened this issue Apr 9, 2023 · 0 comments · Fixed by #2964
Closed

Improve logging output of aso-gen #2853

theunrepentantgeek opened this issue Apr 9, 2023 · 0 comments · Fixed by #2964
Assignees
Milestone

Comments

@theunrepentantgeek
Copy link
Member

Describe the current behavior

Currently our generator uses klog for output, which results in every line including this standard hard coded prefix:

 I0406 08:02:36.555009   23800 resource_importer.go:130]

While this prefix is excellent for background services, it is less valuable for a console application - and I suspect serves to make the generator more intimidating to use.

For those of us who created the generator, this isn't a factor, but for anyone looking to contribute to the operator (especially for developers wanting to contribute a specific resource), there's a distinct possibility of the output dissuading the contribution.

Describe the improvement

I suggest we refactor the generator to use the standard logr.Logger API, and to use a more friendly logger (perhaps zerolog in console mode).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants