-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pre release prep #1251
Pre release prep #1251
Conversation
chidozieononiwu
commented
Dec 4, 2020
•
edited
Loading
edited
- Add Prepare-Release script.
The following pipelines have been queued for testing: |
f58d09f
to
dd9c3f6
Compare
The following pipelines have been queued for testing: |
dd9c3f6
to
7b460eb
Compare
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
e6d5693
to
3004ff9
Compare
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
8ad5abd
to
8565bc1
Compare
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
19cfbb1
to
12ff44c
Compare
The following pipelines have been queued for testing: |
3b437b3
to
2b00586
Compare
The following pipelines have been queued for testing: |
2b00586
to
ad17dd5
Compare
The following pipelines have been queued for testing: |
0a43a07
to
6027d3f
Compare
The following pipelines have been queued for testing: |
…elpers.ps1, improve error message, add logic to detect changes made by prepare-release script
b030964
to
10ff47e
Compare
The following pipelines have been queued for testing: |
The following pipelines have been queued for testing: |
[string]$PackageName, | ||
[string]$ServiceDirectory, | ||
[string]$ReleaseDate, # Pass Date in the form MM/dd/yyyy" | ||
[string]$BuildType # For Java |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of requiring this for Java we should consider setting it the java package properties. I think we can figure out the value there and we can probably just default it there if we don't know the value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will require a separate work to get it working correctly for all the languages without causing other issues. I have opened an issue to track that #1333
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple minor comments but overall looks good.
7596d7a
to
fc68506
Compare
The following pipelines have been queued for testing: |
fc68506
to
f30cee0
Compare
The following pipelines have been queued for testing: |
Hello @azure-sdk! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
@chidozieononiwu now that we have this prepare-release script committed we need to add some documentation about how to use it. Probably some where under https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/8/Releasing-Packages?anchor=script-to-create-and-update-package-work-items. Then post information about it in the various team channels so folks know we added this support. |