Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR Workflow] Add "Next steps to merge this PR" comment #6617

Closed
konrad-jamrozik opened this issue Jul 31, 2023 · 0 comments
Closed

[PR Workflow] Add "Next steps to merge this PR" comment #6617

konrad-jamrozik opened this issue Jul 31, 2023 · 0 comments
Assignees
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.

Comments

@konrad-jamrozik
Copy link
Contributor

konrad-jamrozik commented Jul 31, 2023

There are some issues with the current ARM PR review workflow:

Currently the main methods of guiding PR authors we have are:

The problem with the diagram is that it doesn't tell the PR author where they are on that diagram.

The problem with the check is two-fold.

First, once it is green, there is still more work to do - user needs to get the PR approved and denote they wish to get their PR merged, even after it is approved. Quite often they need extra time before they want to merge their spec updates.

Second, such check would be a weird place to tell people their "next steps". Instead, it is, well, a check.

This work item is a bout adding a PR comment "Next steps to get this PR merged" that will complement the diagram and the check. It will tell the PR author where they are on the diagram and exactly what they need to do. The comment may use the check as a dependency, or the PR author may look at the check to do a "sanity check" if they understand what is going on.

Once this new comment is in place, we might end up getting rid of some of the other comments, to reduce the amount of text the PR authors have to read, and thus increasing the probability they will actually read it.

Additional discussion here.

Related work:

PRs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo.
Projects
Archived in project
Status: 🎊 Closed
Development

No branches or pull requests

1 participant