Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LintDiff][False positive] pipeline is showing false positive on LRO of delete #5862

Open
ArcturusZhang opened this issue Mar 30, 2023 · 2 comments
Open

[LintDiff][False positive] pipeline is showing false positive on LRO of delete #5862

ArcturusZhang opened this issue Mar 30, 2023 · 2 comments
Assignees
@konrad-jamrozik
Labels
ARM bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. Support

Comments

@ArcturusZhang
Copy link
Member

open this issue from this comment: Azure/azure-rest-api-specs#23085 (comment)
This delete operation has the x-ms-long-running-operation: true with 200 and 204, but reported by the linter to require a 200 or 204 which is a false positive.
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Mar 30, 2023
@ArcturusZhang ArcturusZhang mentioned this issue Mar 30, 2023
Merged
11 tasks
@konrad-jamrozik konrad-jamrozik added Central-EngSys This issue is owned by the Engineering System team. Support and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Mar 30, 2023
@konrad-jamrozik
Copy link
Contributor

Thank you @ArcturusZhang for reporting this. Until this is solved, please proceed with merging PRs in spite of this false positive.

@konrad-jamrozik konrad-jamrozik moved this from 🤔Triage to 🐝 Dev in Azure SDK EngSys 🤖🧠 Mar 30, 2023
@konrad-jamrozik konrad-jamrozik added Spec PR Tools Tooling that runs in azure-rest-api-specs repo. and removed Spec PR Tools Tooling that runs in azure-rest-api-specs repo. labels Mar 31, 2023
@konrad-jamrozik konrad-jamrozik changed the title LintDiff pipeline is show false positive on LRO of delete LintDiff pipeline is showing false positive on LRO of delete Apr 4, 2023
@konrad-jamrozik konrad-jamrozik moved this from 🐝 Dev to 📋Backlog in Azure SDK EngSys 🤖🧠 Apr 6, 2023
@konrad-jamrozik konrad-jamrozik added the bug This issue requires a change to an existing behavior in the product in order to be resolved. label Apr 10, 2023
@konrad-jamrozik konrad-jamrozik moved this to 📋 Backlog in Spec PR Tools May 2, 2023
@konrad-jamrozik konrad-jamrozik changed the title LintDiff pipeline is showing false positive on LRO of delete [LintDiff] pipeline is showing false positive on LRO of delete May 9, 2023
@rkmanda rkmanda added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 17, 2023
@rkmanda
Copy link
Member

rkmanda commented May 17, 2023

Task 22896654: Fix LongRunningResponseStatusCode

@rkmanda rkmanda removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label May 17, 2023
@konrad-jamrozik konrad-jamrozik changed the title [LintDiff] pipeline is showing false positive on LRO of delete [LintDiff][False positive] pipeline is showing false positive on LRO of delete May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@konrad-jamrozik konrad-jamrozik

Labels
ARM bug This issue requires a change to an existing behavior in the product in order to be resolved. Central-EngSys This issue is owned by the Engineering System team. Spec PR Tools Tooling that runs in azure-rest-api-specs repo. Support
Projects
Azure SDK EngSys 🤖🧠
Status: 📋 Backlog
Spec PR Tools
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
3 participants
@konrad-jamrozik @ArcturusZhang @rkmanda