Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

APIView - Auto generate swagger API review from Spec PR #4441

Closed
praveenkuttappan opened this issue Oct 17, 2022 · 5 comments
Closed

APIView - Auto generate swagger API review from Spec PR #4441

praveenkuttappan opened this issue Oct 17, 2022 · 5 comments
Assignees
@ruowan
Labels
APIView Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.

Comments

@praveenkuttappan
Copy link
Member

We have added manual swagger API review gen support in APIView. This issue is to track the feature to support autogenerating API review from Swagger spec PR.
@praveenkuttappan praveenkuttappan moved this to 🆕 New in ApiView Oct 17, 2022
@maririos maririos moved this from 🆕 New to 📋 Backlog in ApiView Oct 17, 2022
@ruowan
Copy link
Member

ruowan commented Oct 19, 2022 •
edited
Loading

Hi, @praveenkuttappan . Our swagger pipeline need to download the swagger-api-parser tool. Could you share how to download swagger-pi-parser from pipeline?

@maririos maririos moved this from 📋 Backlog to 🏗 In progress in ApiView Nov 2, 2022
@maririos maririos mentioned this issue Nov 4, 2022
Closed
@praveenkuttappan praveenkuttappan mentioned this issue Nov 4, 2022
Closed
@ruowan
Copy link
Member

ruowan commented Nov 10, 2022 •
edited
Loading

@maririos I already deploy it to prod. We could close it. Here is an example Azure/azure-rest-api-specs#21422 (comment)

@maririos
Copy link
Member

Thanks for the heads up!!
Question, I see these 2 comments in the PR you have linked. Waht is the behavior?

image

Couple comments lower:
image

@maririos
Copy link
Member

Also, should we see it in every PR? i.e. Azure/azure-rest-api-specs#21510

@ruowan
Copy link
Member

ruowan commented Nov 11, 2022 •
edited
Loading

Pls ignore the second comments. It was commented by SDK APIView by mistake. I think it won't comment again. For PR target branch is main, RPSaaSMaster, release-* . The apiView should be generated. I saw there are still some PR which generation succeed but apiView service return 401. @praveenkuttappan have a issue to fix them.

Repository owner moved this from 🏗 In progress to ✅ Done in ApiView Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruowan ruowan

Labels
APIView Central-EngSys This issue is owned by the Engineering System team. EngSys This issue is impacting the engineering system.
Projects
ApiView
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@maririos @ruowan @praveenkuttappan