Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APIView: Cross-Language API reviews #4033

Open
3 tasks done
mikekistler opened this issue Aug 30, 2022 · 6 comments
Open
3 tasks done

APIView: Cross-Language API reviews #4033

mikekistler opened this issue Aug 30, 2022 · 6 comments
Assignees
Labels
APIView Central-EngSys This issue is owned by the Engineering System team. Epic TypeSpec Issues or feature requests for tooling to support TypeSpec (Cadl) WS: Process Tools & Automation Cadl adoption work stream - Process, tools & Automation

Comments

@mikekistler
Copy link
Member

mikekistler commented Aug 30, 2022

For DPG generated libraries we need a way to review all the languages together with the Cadl/OpenAPI source used for generation in one ApiView review.

The Cadl/OpenAPI and each language should be shown in separate tabs and switching tabs should maintain context -- meaning that if the user is viewing a particular operation in Python and switches to the Cadl/OpenAPI tab, the content in that tab will be scrolled to the same operation as the Python tab.

We may also want special handling of comments, such as showing comments from all tabs in the OpenAPI/Cadl view (since presumably that's where the changes would be needed).

Tasks

Preview Give feedback
  1. APIView APIView Priority 1 TypeSpec
    tjprescott
@mikekistler mikekistler added APIView Central-EngSys This issue is owned by the Engineering System team. labels Aug 30, 2022
@azure-sdk azure-sdk moved this to 🆕 New in ApiView Aug 30, 2022
@azure-sdk azure-sdk moved this to 🤔Triage in Azure SDK EngSys 🤖🧠 Aug 30, 2022
@joshfree
Copy link
Member

@JonathanGiles

@JonathanGiles
Copy link
Member

I think a way that would work is something like this: you start in the CADL view, you click on some definition, and a right-blade appears with a tabbed interface for each language. In each tab is a fully-fledged APIView, with the selected language-specific code highlighted. This will resolve issues with flicking between tabs, because we never leave the CADL review, and it also means we can see all associated code with the highlighting, even if it is in different parts of the review for each language.

@maririos maririos added Epic TypeSpec Issues or feature requests for tooling to support TypeSpec (Cadl) WS: Process Tools & Automation Cadl adoption work stream - Process, tools & Automation labels Aug 31, 2022
@mikekistler mikekistler moved this from 🆕 New to 📋 Backlog in ApiView Sep 26, 2022
@MrJustinB MrJustinB added this to the 2023-03 milestone Oct 6, 2022
@maririos
Copy link
Member

maririos commented Jan 5, 2023

Small step in this direction: #4677

@maririos maririos modified the milestones: 2023-03, 2023-05 Jan 5, 2023
@maririos maririos modified the milestones: 2023-05, 2023-03 Jan 19, 2023
@maririos
Copy link
Member

Recent APIView deployment includes a step in this direction. See Fro example this review that got created from an APISpec:

Image

@MrJustinB
Copy link
Member

Phase 1 is complete. Phase 2 is planned for 1H Gallium

@chidozieononiwu chidozieononiwu moved this from 🤔 Triage to 🐝 Dev in Azure SDK EngSys 🤖🧠 Sep 5, 2023
@maririos maririos moved this from 📋 Backlog to 🏗 In progress in ApiView Sep 11, 2023
@maririos maririos modified the milestones: 2023-09, 2023-12 Sep 12, 2023
@maririos maririos changed the title Cross-Language API reviews in ApiView Cross-Language API reviews in ApiView (POC) Sep 12, 2023
@MrJustinB MrJustinB changed the title Cross-Language API reviews in ApiView (POC) APIView: Cross-Language API reviews (POC) Sep 21, 2023
@chidozieononiwu chidozieononiwu moved this from 🏗 In progress to ✅ Done in ApiView Mar 13, 2024
@maririos maririos moved this from ✅ Done to 🏗 In progress in ApiView Mar 20, 2024
@maririos maririos removed this from the 2023-12 milestone Mar 20, 2024
@kurtzeborn kurtzeborn moved this from 🐝 Dev to 🎊 Closed in Azure SDK EngSys 🤖🧠 Apr 23, 2024
@maririos
Copy link
Member

This work has stopped until #8174 and #5897 are stable

@maririos maririos moved this from 🏗 In progress to 📋 Backlog in ApiView Jul 31, 2024
@maririos maririos moved this from 🎊 Closed to 📋 Backlog in Azure SDK EngSys 🤖🧠 Jul 31, 2024
@maririos maririos changed the title APIView: Cross-Language API reviews (POC) APIView: Cross-Language API reviews Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APIView Central-EngSys This issue is owned by the Engineering System team. Epic TypeSpec Issues or feature requests for tooling to support TypeSpec (Cadl) WS: Process Tools & Automation Cadl adoption work stream - Process, tools & Automation
Projects
Status: 📋 Backlog
Status: 📋 Backlog
Development

No branches or pull requests

7 participants