Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email for customer reported issues in invalid state should not include PRs #1255

Closed
ramya-rao-a opened this issue Dec 7, 2020 · 4 comments · Fixed by #1271
Closed

Email for customer reported issues in invalid state should not include PRs #1255

ramya-rao-a opened this issue Dec 7, 2020 · 4 comments · Fixed by #1271
Assignees
@mitchdenny
Labels
Central-EngSys This issue is owned by the Engineering System team.

Comments

@ramya-rao-a
Copy link

The current email notification for customer reported issues in invalid state includes PRs which should not be happening. My guess is that this started happening ever since PRs started getting labels. This makes the report very noisy.

cc @AlexGhiondea @mitchdenny @weshaggard
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Dec 7, 2020
@kurtzeborn kurtzeborn added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Dec 8, 2020
@mitchdenny mitchdenny mentioned this issue Dec 10, 2020
Merged
@ramya-rao-a
Copy link
Author

Today's email on customer reported issues in invalid state contained PRs as well.
I see #1271 is merged. Should anything else need to happen to deploy the fix?

@mitchdenny
Copy link
Contributor

Hrm ... it should be deployed. Let me check.

@mitchdenny
Copy link
Contributor

My bad, I timed out the final approval but when I went back to it misread it and thought it deployed! Fixing now.

@mitchdenny
Copy link
Contributor

Deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitchdenny mitchdenny

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Filter PRs from search for invalid customer issues. mitchdenny/azure-sdk-tools
3 participants
@mitchdenny @ramya-rao-a @kurtzeborn