Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot should not consider customer reported PRs to be in invalid state due to lack of Client/Mgmt/bug/question/feature request labels #1107

Closed
ramya-rao-a opened this issue Oct 19, 2020 · 2 comments
Closed

Bot should not consider customer reported PRs to be in invalid state due to lack of Client/Mgmt/bug/question/feature request labels #1107

ramya-rao-a opened this issue Oct 19, 2020 · 2 comments
Assignees
@mitchdenny
Labels
Central-EngSys This issue is owned by the Engineering System team.
Milestone
Backlog

Comments

@ramya-rao-a
Copy link

In the weekly email for customer reported issues in an invalid state, PRs are now being included.
Examples:

Am guessing this is because the rules dont differentiate between PRs and issues?

While we can update the CodeOwners file to add the Client labels to PRs made to the data plane libraries, the other rule that looks for one of bug/question/feature-request labels does not apply to PRs
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Oct 19, 2020
@ramya-rao-a
Copy link
Author

cc @mitchdenny, @AlexGhiondea, @weshaggard

@kurtzeborn kurtzeborn added Central-EngSys This issue is owned by the Engineering System team. and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Oct 29, 2020
@mitchdenny mitchdenny modified the milestones: [2020] December, Backlog Nov 3, 2020
@mitchdenny
Copy link
Contributor

I believe that this was addressed in PR: #1271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mitchdenny mitchdenny

Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@mitchdenny @ramya-rao-a @kurtzeborn