Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KeyVault] Data-plane updates to support multi api #3053

Merged
merged 15 commits into from
Aug 7, 2018

Conversation

schaabs
Copy link
Member

@schaabs schaabs commented Jul 31, 2018

Still working on the test updates but submitting pull request so we can develop the CLI updates in parallel.

@schaabs schaabs requested a review from lmazuel July 31, 2018 20:03
@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@codecov-io
Copy link

codecov-io commented Jul 31, 2018

Codecov Report

Merging #3053 into master will decrease coverage by 0.38%.
The diff coverage is 64.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3053      +/-   ##
==========================================
- Coverage   57.59%    57.2%   -0.39%     
==========================================
  Files        7845     8002     +157     
  Lines      159380   162394    +3014     
==========================================
+ Hits        91796    92903    +1107     
- Misses      67584    69491    +1907
Impacted Files Coverage Δ
.../v2016_10_01/models/certificate_issuer_item_py3.py 57.14% <ø> (ø)
...vault/azure/keyvault/v7_0/models/key_properties.py 100% <ø> (ø)
...t/azure/keyvault/v2016_10_01/models/trigger_py3.py 62.5% <ø> (ø)
...ault/azure/keyvault/v7_0/models/lifetime_action.py 100% <ø> (ø)
...ult/azure/keyvault/v7_0/models/certificate_item.py 100% <ø> (ø)
azure-keyvault/azure/keyvault/key_vault_client.py 74.73% <ø> (-2.26%) ⬇️
...azure/keyvault/v7_0/models/certificate_item_py3.py 100% <ø> (ø)
...e-keyvault/azure/keyvault/v7_0/models/error_py3.py 100% <ø> (ø)
...yvault/v2016_10_01/models/secret_properties_py3.py 66.66% <ø> (ø)
...2016_10_01/models/subject_alternative_names_py3.py 50% <ø> (ø)
... and 535 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d98e5d...65cb175. Read the comment docs.

@schaabs schaabs mentioned this pull request Aug 2, 2018
@schaabs schaabs changed the title [KeyVault] Data-plane updates to support multi api [Do Not Merge] [KeyVault] Data-plane updates to support multi api Aug 6, 2018
@schaabs schaabs merged commit bfcd947 into Azure:master Aug 7, 2018
@schaabs schaabs deleted the dp-multi-api branch August 7, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants