Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applying some of the comments received from Azure Board #21645

Merged
merged 488 commits into from
Nov 15, 2021
Merged

Applying some of the comments received from Azure Board #21645

merged 488 commits into from
Nov 15, 2021

Conversation

cochi2
Copy link
Contributor

@cochi2 cochi2 commented Nov 8, 2021

No description provided.

xiafu-msft and others added 30 commits October 15, 2021 21:27
@xiafu-msft
fix for service principal environment vars (Azure#21287)
8af1100
@xiafu-msft
[Storage]fix type annotation (Azure#20096)
524fd74
@xiafu-msft
[Storage][Logging]Let users opt in logging_request_body (Azure#19710)
fee8f87 
* [Storage][Logging]Let users opt in logging_request_body

* Update policies.py

* Update policies.py

* Update policies.py

* Update policies.py

* logging response body

* Update settings_fake.py
@xiafu-msft
Feature/storage stg79 (Azure#21286)
14496e7 
* update swagger

* encryption scope sas

* permanent delete sas

* sync copy from url with encryption scope

* manually edit swagger

* Update _version.py
@chengliangli0918 @charlili1234
@rsamigullin @matthchr
[AutoRelease] t2-containerservice-2021-10-18-97657 (Azure#21294)
b39af12 
* CodeGen from PR 16215 in Azure/azure-rest-api-specs
Dev containerservice microsoft.container service 2021 09 01 (Azure#16215)

* Adds base for updating Microsoft.ContainerService from version stable/2021-08-01 to version 2021-09-01

* Updates readme

* Updates API version in new specs and examples

* Add gmsaProfile in WindowsProfile for AKS (Azure#15976)

* Add gmsaProfile in WindowsProfile for AKS

* fix spell errors

* Fix lint issue

* Update readme.md for AKS 2021-09-01

* Expose a few more snapshot properties in 2021-09-01 swagger to match 2021-09-01 API (Azure#16082)

* Expose a few more snapshot properties in 2021-09-01 swagger to match 2021-09-01 RP API

* Expose a few more snapshot properties in 2021-09-01 swagger to match 2021-09-01 RP API

Co-authored-by: Charlie Li <charlili@microsoft.com>

* Agent pool start/stop  (Azure#16105)

* added examples for agentpool start/stop

* fixed code styling

* added 201 response code in examples

* added 201 response code object

* added missing parameter

* updated description for power state and added title

* added power state to request body properties

* Update specification/containerservice/resource-manager/Microsoft.ContainerService/stable/2021-09-01/managedClusters.json

Co-authored-by: Matthew Christopher <matthchr@microsoft.com>

Co-authored-by: Matthew Christopher <matthchr@microsoft.com>

Co-authored-by: Charlie Li <39974812+chengliangli0918@users.noreply.github.com>
Co-authored-by: Charlie Li <charlili@microsoft.com>
Co-authored-by: rsamigullin <89222124+rsamigullin@users.noreply.github.com>
Co-authored-by: Matthew Christopher <matthchr@microsoft.com>

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Charlie Li <39974812+chengliangli0918@users.noreply.github.com>
Co-authored-by: Charlie Li <charlili@microsoft.com>
Co-authored-by: rsamigullin <89222124+rsamigullin@users.noreply.github.com>
Co-authored-by: Matthew Christopher <matthchr@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
@azure-sdk
Increment package version after release of azure-messaging-webpubsubs…
10be9c3 
…ervice (Azure#21280)
@azure-sdk
Increment version for purview releases (Azure#21279)
e7995f9 
* Increment package version after release of azure-purview-administration

* Increment package version after release of azure-purview-catalog

* Increment package version after release of azure-purview-scanning
@Codejune
[WIP]Refactor AzureJSONEncoder (Azure#21028)
3ee208c 
* Refactor AzureJSONEncoder

* Improved readability of AzureJSONEncoder datetime handling

* Rename _timestr_as_isostr() to _datetime_as_isostr()
* Move datetime.timedelta object handling function call (_timedelta_as_str()) to _datetime_as_isostr() inside
* Rename private method (_datetime_as_isostr, _timedelta_as_str) parameter value, o to dt, td

* Add some docstring

* Fix typo and add type checking

* Fix typo some docstring 
* Renamed _timedelta_as_str to _timedelta_as_isostr
* Add type checking in _datetime_as_isostr

* Improve type checking and rename some inner variables
@xiangyan99
update changelog (Azure#21308)
1842c21
@azure-sdk @scbedd
adjust the docker-start-proxy to take advantage of the linux specific…
078e520 
… commands that allow contact of localhost (Azure#21310)

Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
@mccoyp
Remove link to private repo (Azure#21312)
f4ea90a
@xiangyan99
fix uri (Azure#20632)
2597a6b 
* fix uri

* update

* update changelog

* udpates
@catalinaperalta
[formrecognizer] Add proper defaults on DocumentTableCell (Azure#21213)
5093472 
* add proper defaults on document table cell

* default kind field

* set default in _from_generated and improve init

* revert changes to init, fix test comment

* set content default for kind

* update testcase to account for default scenarios
@azure-sdk @sima-zhu @benbp
Sync eng/common directory with azure-sdk-tools for PR 2100 (Azure#21311)
b18df5e 
* Add group id into metadata for java use

* Update Update-DocsMsPackages.ps1

* Update Update-DocsMsPackages.ps1

* Update eng/common/scripts/Update-DocsMsPackages.ps1

Co-authored-by: Ben Broderick Phillips <ben@benbp.net>

* Update eng/common/scripts/Update-DocsMsPackages.ps1

Co-authored-by: Ben Broderick Phillips <ben@benbp.net>

Co-authored-by: Sima Zhu <sizhu@microsoft.com>
Co-authored-by: Sima Zhu <48036328+sima-zhu@users.noreply.github.com>
Co-authored-by: Ben Broderick Phillips <ben@benbp.net>
@tasherif-msft
Revert "Feature/storage stg79 (Azure#21286)" (Azure#21317)
9f91027 
This reverts commit 14496e7.
@azure-sdk @chidozieononiwu
Sync eng/common directory with azure-sdk-tools for PR 2085 (Azure#21325)
e461efc 
* Fix up identity resolver to make it more reliable, publish notification configuration as a tool

* Use both username and email to resolve queuing user

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
@RAY-316
[AutoRelease] t2-recoveryservicesbackup-2021-10-19-33781 (Azure#21330)
f8bbfa9 
* CodeGen from PR 15881 in Azure/azure-rest-api-specs
[Hub Generated] Review request for Microsoft.RecoveryServices to add version stable/2021-08-01 (Azure#15881)

* Adds base for updating Microsoft.RecoveryServices from version stable/2021-07-01 to version 2021-08-01

* Updates readme

* Updates API version in new specs and examples

* Fixing readme file

* version,CHANGELOG

* Update CHANGELOG.md

* Update CHANGELOG.md

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Zed Lei <59104634+RAY-316@users.noreply.github.com>
@azure-sdk @scbedd
update to latest test-proxy tag (Azure#21334)
375337f 
Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
@mikeharder
[Perf] Support multiple test proxies (Azure#21203)
882ae75 
- Some scenarios require multiple test-proxy URLs to bottleneck client
- test-proxy URLs are assigned round-robin to parallel test instances
- Ported from Azure/azure-sdk-for-net#24265
@sikasire @msyyc
[AutoRelease] t2-hybridkubernetes-2021-10-04-45305 (Azure#21037)
d24809b 
* CodeGen from PR 15956 in Azure/azure-rest-api-specs
New GA version changes - 2021-10-01 (Azure#15956)

* New GA api-version changes- 2021-01-01

* readme changes

* readme changes

* add systemdata definition

* system data ref fix

* system data ref fix

* fix

* fix

* fix

* remove empty patch section

* revert patch section

* lint fix

* lint fix

* lintfix

* readme changes

* Update readme.md

* remove property bag from cc update example

* Fixing listClusterUserCreds examples

* hide creds

* example file naming changes and clientProxy flag correction

Co-authored-by: Siri Teja Reddy Kasireddy <sikasire@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>

* version,CHANGELOG

* Update CHANGELOG.md

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: Siri Teja Reddy Kasireddy <sikasire@microsoft.com>
Co-authored-by: msyyc <70930885+msyyc@users.noreply.github.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
@RAY-316
del useless version (Azure#21345)
e4c21c4
@AikoBB
Updating CODEOWNERS for ACS Identity (Azure#20881)
f4354a6 
Co-authored-by: Aigerim Beishenbekova <aigerimb@Aigerims-MacBook-Pro.local>
@iscai-msft
[core] fix isinstace str check in core rest (Azure#21341)
e8b43ed
@azure-sdk @chidozieononiwu
Sync eng/common directory with azure-sdk-tools for PR 2093 (Azure#21350)
0c43e94 
* Consume Codeowners parser library, ceperate users from teams in codeownerse

* Update get-pr-owners and related logic

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
@tjprescott
[Search] Update for missing properties (Azure#21205)
81536f7 
* Expose select kwarg on list operations.

* Update search for missing properties: session_id, scoring_statistics

* Update `SearchIndexerDataSourceConnection` missing properties: identity, encryption_key

* Fix linter issues.

* Update CHANGELOG.
[ACR] React to stable/2021-07-01 swagger changes (Azure#21110)
d3bda33
@tasherif-msft
Fix OrMetadata (Azure#21316)
b708e17 
* settings files

* OrMedata Fix
[AutoRelease] t2-chaos-2021-10-21-14806 (Azure#21354)
50f4c44 
* CodeGen from PR 16453 in Azure/azure-rest-api-specs
Adding Microsoft.Chaos API Version 2021-09-15-preview. (Azure#16453)

* [baseline] Microsoft.Chaos private preview API Version 2021-09-15-preview.

* msft.chaos PublicPreview API 2021-09-15-preview
* Add neccessary readme's from swagger tool branch generation.
* remove artifiact resource from public preview.
* fix static linter issues.

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
@msyyc
[AutoRelease] t2-dataprotection-2021-10-19-69515 (Azure#21333)
a5cdc52 
* CodeGen from PR 16451 in Azure/azure-rest-api-specs
Update readme.python.md (Azure#16451)

* Update readme.python.md

* config readme

* version,CHANGELOG

Co-authored-by: SDKAuto <sdkautomation@microsoft.com>
Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
@msyyc
docs (Azure#21360)
a98b5db
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@zihzhan-msft zihzhan-msft merged commit f081515 into Azure:feature/communication-CallingServer-preview Nov 15, 2021
@cochi2 cochi2 deleted the fmorales/azure_board branch November 30, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zihzhan-msft zihzhan-msft zihzhan-msft approved these changes

Assignees
No one assigned
Labels
Communication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.