[Tables] Make credential parameter keyword-only #19117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run python - tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| @@ -65,7 +65,7 @@ async def delete_entity(self): | |||
| from azure.core.credentials import AzureNamedKeyCredential | |||
|
|
|||
| credential = AzureNamedKeyCredential(self.account_name, self.access_key) | |||
| table_client = TableClient(endpoint=self.endpoint, credential=credential, table_name=self.table_name) | |||
| table_client = TableClient(endpoint=self.endpoint, table_name=self.table_name, credential=credential) | |||
There was a problem hiding this comment.
nit: does this have to be the last keyword?
There was a problem hiding this comment.
It doesn't, but given the endpoint, table_name are the two positional parameters - I thought for the samples it would be best to demonstrate the correct order. I didn't bother swapping them in the tests ;)
| @@ -36,7 +36,7 @@ class StorageTableTest(AzureTestCase, TableTestCase): | |||
| def test_create_properties(self, tables_storage_account_name, tables_primary_storage_account_key): | |||
| # # Arrange | |||
| account_url = self.account_url(tables_storage_account_name, "table") | |||
| ts = self.create_client_from_credential(TableServiceClient, tables_primary_storage_account_key, endpoint=account_url) | |||
| ts = TableServiceClient(credential=tables_primary_storage_account_key, endpoint=account_url) | |||
There was a problem hiding this comment.
If this passes I'd keep it for now, but you can also change it to credential=tables_primary_storage_account_key. Small nit
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Jun 9, 2022
Support.json Get Support Ticket serviceId + ProbClassId filter changes (Azure#19117) * Support.json Get Support Ticket serviceId + ProbClassId filter changes * Add list tickets service + probClassId examples * Reference example files in support.json * List Support tickets example files formatting * Service Id problem class id example prettier format fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.