-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Storage][Test] Test multiple service versions #19039
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
19df257
adding infra for specifying service version from env var or by default
seankane-msft a205f3e
changes for blob to show usage
seankane-msft 5b52e48
updates for storage-queue
seankane-msft db1a868
adding bens comment and assert policy for blob
seankane-msft 508e5dd
removing
seankane-msft 741b098
key change
seankane-msft 519ab4a
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-pytho…
seankane-msft fa78e37
fixing way service version is read
seankane-msft bbbb81f
fixing an issue
seankane-msft 7fec5e9
adding skipif the sv is too low
seankane-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
16 changes: 16 additions & 0 deletions
16
sdk/storage/azure-storage-blob/tests/_shared/service_versions.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
from enum import Enum | ||
|
||
|
||
class ServiceVersion(str, Enum): | ||
|
||
V2019_02_02 = "2019-02-02" | ||
V2019_07_07 = "2019-07-07" | ||
V2019_12_12 = "2019-12-12" | ||
V2020_02_10 = "2020-02-10" | ||
V2020_04_08 = "2020-04-08" | ||
V2020_06_12 = "2020-06-12" | ||
V2020_08_04 = "2020-08-04" | ||
|
||
|
||
LATEST_SERVICE_VERSION = ServiceVersion.V2020_08_04 | ||
LATEST_SERVICE_VERSION_PLUS_1 = ServiceVersion.V2020_06_12 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"matrix": { | ||
"Agent": { | ||
"ubuntu-18.04": { "OSVmImage": "MMSUbuntu18.04", "Pool": "azsdk-pool-mms-ubuntu-1804-general" }, | ||
"windows-2019": { "OSVmImage": "MMS2019", "Pool": "azsdk-pool-mms-win-2019-general" } | ||
}, | ||
"JavaTestVersion": [ "1.8", "1.11" ], | ||
"AZURE_TEST_HTTP_CLIENTS": [ "okhttp", "netty" ], | ||
"TestGoals": "surefire:test", | ||
"AZURE_LIVE_TEST_SERVICE_VERSION": [ | ||
"V2019_02_02", | ||
"V2019_07_07", | ||
"V2019_12_12", | ||
"V2020_02_10", | ||
"V2020_04_08", | ||
"V2020_06_12", | ||
"V2020_08_04" | ||
] | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"matrix": { | ||
"$IMPORT": "eng/pipelines/templates/stages/platform-matrix.json" | ||
}, | ||
"exclude": [ | ||
{ "OSVmImage": "macOS-10.15" } | ||
], | ||
"include": [ | ||
{ | ||
"Agent": { "macOS-10.15": { "OSVmImage": "macOS-10.15", "Pool": "Azure Pipelines" } }, | ||
"JavaTestVersion": "1.8", | ||
"AZURE_TEST_HTTP_CLIENTS": "netty" | ||
seankane-msft marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}, | ||
{ | ||
"Agent": { "macOS-10.15": { "OSVmImage": "macOS-10.15", "Pool": "Azure Pipelines" } }, | ||
"JavaTestVersion": "1.11", | ||
"AZURE_TEST_HTTP_CLIENTS": "okhttp" | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in nightly pipeline we'd like clients to pick the default, i.e. env variable is empty.
does this code achieve this by leaving "api_version" kwarg empty or we need some "if" here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the environment variable is empty, it will default to
LATEST_SERVICE_VERSION