[Communication]: Added exception to begin_update_phone_number_capabilities #18025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
minnieliu
reviewed
Apr 14, 2021
| phone_number, | ||
| calling=calling, | ||
| sms=sms, | ||
| **kwargs | ||
| ) | ||
|
|
||
| result_properties = poller.result().additional_properties | ||
| if 'status' in result_properties and result_properties['status'] == 'failed': |
There was a problem hiding this comment.
Is this check case sensitive?
There was a problem hiding this comment.
Yes, this check is case sensitive.
There was a problem hiding this comment.
Discussed this offline. The status value isn't always lower case, so this check should handle that.
jbeauregardb
approved these changes
Apr 14, 2021
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
beltr0n
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to address the case when the service returns a response with the status code 200 and an error in the body.