Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tables] Adding azurite support #17944

Merged
5 commits merged into from
Apr 19, 2021
Merged

[Tables] Adding azurite support #17944

5 commits merged into from
Apr 19, 2021

Conversation

seankane-msft
Copy link
Member

@seankane-msft seankane-msft self-assigned this Apr 9, 2021
@seankane-msft
Copy link
Member Author

@v-xuto can you elaborate on how to best test these changes? Is there a way to spin up azurite in the azure devops? Are there any limitations to azurite or does it have the exact same functionality as the Tables service>

@seankane-msft
Copy link
Member Author

@v-xuto I tested locally and I get an error on the sample code you provided:

Error: *Internal Azurite Error*: content-type value application/json;odata=nometadata is not supported by Azurite.

@v-xuto
Copy link
Member

v-xuto commented Apr 12, 2021

@seankane-msft - I tested it locally based on the code you modified, and the result was successful. I use this repo: https://github.com/Azure/Azurite, switch to the branch table, start azurite. Below are the values of account_url and access_key that I used. The values of these variables are provided in the readme.

account_url = 'https://127.0.0.1:10002/devstoreaccount1'
access_key = 'Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw=='

Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - changelog update?

@ghost
Copy link

ghost commented Apr 16, 2021

Hello @seankane-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@seankane-msft
Copy link
Member Author

/azp run python - tables - ci

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@ghost ghost merged commit 4d29aef into Azure:master Apr 19, 2021
@seankane-msft seankane-msft deleted the tables-azurite branch April 19, 2021 18:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants