[Container Registry] Transport wrapper #17633
Conversation
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
| async def test_transport_closed_only_once(self, containerregistry_baseurl): | ||
| transport = AioHttpTransport() | ||
| client = self.create_registry_client(containerregistry_baseurl, transport=transport) | ||
| async with client: |
There was a problem hiding this comment.
I'm sorry idk how this test checks that the transport is only closed once :'(
If this isn't checking the transport's only closed once, you can look at @chlowell 's test here to gain inspo https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/keyvault/azure-keyvault-certificates/tests/test_context_manager.py#L10
There was a problem hiding this comment.
@seankane-msft can correct me, but I think we're testing that the child client does not close the transport of the parent client upon exiting the context manager
There was a problem hiding this comment.
Krista is correct, I took inspo from storage https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/storage/azure-storage-blob/tests/test_common_blob.py#L2340-L2351
I can add an issue to address that situation in a later PR @iscai-msft
| @@ -56,3 +57,28 @@ def close(self): | |||
| Calling this method is unnecessary when using the client as a context manager. | |||
| """ | |||
| self._client.close() | |||
|
|
|||
|
|
|||
| class TransportWrapper(HttpTransport): | |||
There was a problem hiding this comment.
Is there an async version of this?
| async def test_transport_closed_only_once(self, containerregistry_baseurl): | ||
| transport = AioHttpTransport() | ||
| client = self.create_registry_client(containerregistry_baseurl, transport=transport) | ||
| async with client: |
There was a problem hiding this comment.
@seankane-msft can correct me, but I think we're testing that the child client does not close the transport of the parent client upon exiting the context manager
|
Hello @seankane-msft! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Addresses #17508 . Adding a transport wrapper to pipelines to ensure sessions are not closed when using context managers. PR is based off another branch not yet in master, need #17540 to be merged first.