[Communication] - Phone Numbers - Changed User-Agent in request #17162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15be2f8 to
df65619
Compare
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
df65619 to
d149ffb
Compare
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sacheu
reviewed
Mar 8, 2021
| item['phoneNumber'] = self._replacement | ||
| elif "id" in item: |
sacheu
reviewed
Mar 8, 2021
| @@ -25,14 +25,14 @@ def process_response(self, response): | |||
| if isinstance(item, str): | |||
| body["phoneNumbers"] = [self._replacement] | |||
| break | |||
| elif "phoneNumber" in item: | |||
There was a problem hiding this comment.
I wanted to sanitize both values. Having an elif only sanitized the phone number or the id, but not both at the same time.
| item['id'] = self._replacement | ||
| response['body']['string'] = json.dumps(body) | ||
| response['url'] = self._replacement | ||
| return response | ||
| except (KeyError, ValueError): | ||
| except (KeyError, ValueError, TypeError): |
There was a problem hiding this comment.
why we need this change for the User-agent change?
There was a problem hiding this comment.
This is a fix for the type error issue we have in the search available phone numbers test. We weren't catching that exception before. It's totally unrelated to the user agent issue, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.