-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
search perf tests #17101
search perf tests #17101
Conversation
self.async_service_client = AsyncAppConfigClient(service_endpoint, index_name, AzureKeyCredential(api_key)) | ||
|
||
async def global_setup(self): | ||
await super().global_setup() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to pre-load any documents into the index in order for the search to actually return results?
Otherwise the perf test might be skipping some results deserialization logic?
And if the returned results are pagable, then iterating through them would also be an important part. Maybe add a configuable --num-documents
flag to set up the number of results we would expect to be returned by the search?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This is covered in the pre-configuration. :)
Azure offers some shared data for customers to try the search service.
https://docs.microsoft.com/en-us/azure/search/search-indexer-tutorial
Importing data and creating index are costy and usually user only needs it once so we don't want to include it in perf tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you say it's covered in the pre-configuration - there's nothing in the readme about it that I can see?
No description provided.