Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

search perf tests #17101

Merged
merged 6 commits into from
Mar 29, 2021
Merged

search perf tests #17101

merged 6 commits into from
Mar 29, 2021

Conversation

xiangyan99
Copy link
Member

No description provided.

@xiangyan99 xiangyan99 requested a review from annatisch March 5, 2021 00:46
@ghost ghost added the Search label Mar 5, 2021
self.async_service_client = AsyncAppConfigClient(service_endpoint, index_name, AzureKeyCredential(api_key))

async def global_setup(self):
await super().global_setup()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to pre-load any documents into the index in order for the search to actually return results?
Otherwise the perf test might be skipping some results deserialization logic?
And if the returned results are pagable, then iterating through them would also be an important part. Maybe add a configuable --num-documents flag to set up the number of results we would expect to be returned by the search?

Copy link
Member Author

@xiangyan99 xiangyan99 Mar 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. This is covered in the pre-configuration. :)

Azure offers some shared data for customers to try the search service.

https://docs.microsoft.com/en-us/azure/search/search-indexer-tutorial

Importing data and creating index are costy and usually user only needs it once so we don't want to include it in perf tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you say it's covered in the pre-configuration - there's nothing in the readme about it that I can see?

@xiangyan99 xiangyan99 requested a review from annatisch March 22, 2021 20:24
@xiangyan99 xiangyan99 requested a review from annatisch March 24, 2021 22:49
@xiangyan99 xiangyan99 merged commit cd8fc1b into master Mar 29, 2021
@xiangyan99 xiangyan99 deleted the search_perf_tests branch March 29, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants