Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demonstrate closing async credentials in Key Vault docs #16793

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Demonstrate closing async credentials in Key Vault docs #16793

merged 2 commits into from
Feb 18, 2021

Conversation

chlowell
Copy link
Member

Closes #16757

@chlowell chlowell added Docs KeyVault Client This issue points to a problem in the data-plane of the library. labels Feb 18, 2021
@chlowell chlowell mentioned this pull request Feb 18, 2021
Closed
@chlowell chlowell enabled auto-merge (squash) February 18, 2021 01:15
mccoyp
mccoyp approved these changes Feb 18, 2021
View reviewed changes
Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pedantry is forgiven and appreciated :shipit:

@chlowell chlowell merged commit 9cb1695 into Azure:master Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mccoyp mccoyp mccoyp approved these changes

@schaabs schaabs Awaiting requested review from schaabs

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Docs KeyVault
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aiohttp SecretClient not closing session.
2 participants
@chlowell @mccoyp