Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ServiceBus] Add body_as_str helper method on ServicBusMessage #16663

Closed
wants to merge 4 commits into from

Conversation

yunhaoling
Copy link
Contributor

@yunhaoling yunhaoling commented Feb 10, 2021

addressing issue: #16453

also align with the EventData method in EventHub SDK (code copied): https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/eventhub/azure-eventhub/azure/eventhub/_common.py#L289-L309

question for @annatisch : should we bump the version to v7.1.0 as this is a new feature?

Copy link
Member

@swathipil swathipil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@rakshith91 rakshith91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM- just to double check - we need this in the ServiceBusReceivedMessage too which is returning a generator right now

@yunhaoling
Copy link
Contributor Author

yunhaoling commented Feb 11, 2021

@rakshith91 , ServiceBusReceivedMessage inherits from ServiceBusMessage, so the helper method is available as well :P
I have updated the changelog to reflect that, thanks for calling it out!

@yunhaoling
Copy link
Contributor Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling
Copy link
Contributor Author

/azp run python - servicebus - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling
Copy link
Contributor Author

closing this PR temporality until there're customer requests

@yunhaoling yunhaoling closed this Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants