[Key Vault] Improved custom role definition support in administration #16556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
reviewed
Feb 5, 2021
| @@ -23,7 +25,7 @@ class RoleDefinitionsOperations: | |||
| instantiates it for you and attaches it as an attribute. | |||
|
|
|||
| :ivar models: Alias to model classes used in this operation group. | |||
| :type models: ~key_vault_client.models | |||
| :type models: ~azure.keyvault.v7_2.models | |||
There was a problem hiding this comment.
It breaks nothing and doesn't need to change, but I'm curious why there are so many docstring references assuming a nonexistent package for 7.2 🤔
chlowell
reviewed
Feb 5, 2021
...yvault/azure-keyvault-administration/azure/keyvault/administration/_access_control_client.py
Outdated
Show resolved
Hide resolved
...eyvault-administration/tests/recordings/test_access_control_async.test_role_definitions.yaml
Outdated
Show resolved
Hide resolved
chlowell
reviewed
Feb 5, 2021
...lt/azure-keyvault-administration/azure/keyvault/administration/aio/_access_control_client.py
Outdated
Show resolved
Hide resolved
chlowell
approved these changes
Feb 5, 2021
...yvault/azure-keyvault-administration/azure/keyvault/administration/_access_control_client.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds off of #16063, adding support for custom role names and descriptions (as well as fixing docstrings).