-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated event hubs migration guide to follow template #15953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakshith91
reviewed
Dec 31, 2020
ramya-rao-a
reviewed
Jan 5, 2021
ramya-rao-a
reviewed
Jan 7, 2021
ramya-rao-a
reviewed
Jan 7, 2021
ramya-rao-a
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left one last comment.
yunhaoling
reviewed
Jan 7, 2021
yunhaoling
reviewed
Jan 7, 2021
yunhaoling
reviewed
Jan 7, 2021
yunhaoling
approved these changes
Jan 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Jan 8, 2021
* updated event hubs migration guide to follow template * made changes based on ramya/rakshith's comments * fixed link in table of contents * fix table of contents again * fixed ramyas comments * fixed last comment * adams comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing: #15105