Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config the default blocksize to 32k for Python 3.7+ #14442

Merged
merged 18 commits into from
Nov 7, 2020

Conversation

xiangyan99
Copy link
Member

@xiangyan99 xiangyan99 commented Oct 12, 2020

Fixes #11044

@ghost ghost added the Azure.Core label Oct 12, 2020
@xiangyan99 xiangyan99 marked this pull request as draft October 12, 2020 19:59
@xiangyan99
Copy link
Member Author

/azp run python - formrecognizer - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xiangyan99 xiangyan99 marked this pull request as ready for review October 14, 2020 16:52
* [metricsadvisor] live tests setup (#14396)

* add live test yml for metrics advisor

* some fixes

* hardcode test ids and rerecord a few tests

* add ids back as env variables

* [formrecognizer] initial business cards (#14026)

* Sync eng/common directory with azure-sdk-tools for PR 1081 (#14445)

Sync eng/common directory with azure-sdk-tools for PR Azure/azure-sdk-tools#1081
 See [eng/common workflow](https://github.com/Azure/azure-sdk-tools/blob/master/eng/common/README.md#workflow)

* Communication Administration: Add on-demand resource creation for live-tests  (#14366)

* Add communication service preparer

* Refactor dynamic resource creation testing code

* Remove setup method of base test class

* Change fake conn str to valid format

* Remove unused import

* Remove main test file

* Reduce RG expiry durtion

* Async test code change with resource preparer

* Add chaching for resource-preparer

* Move helper into shared

* Move preparer into shared

* Uncomment test code

* Remove CommunicationResourceGroupPreparer use common instead

* Add base testcase for sync pnm

* move phone_number_helper to phone_number folder

* Add base pnm async testcase

* Add __init__ for test folders

* Fix identity tests to refer to shared test folder

* Refactor base async phonenumber test class

* Make decorator consisitent across all async tests utm

* Replace fake resource value

* Fix type in test file names

* Remove commented cache setting code

* Add livetest recording files

* Refresh recording files

* Update recording files

* Reorganize the test folder structure

* Add mgmt pacakge to the dev reqs

Co-authored-by: tural farhadov <tufarhad@microsoft.com>

* [ServiceBus] Small stress test and sample touchups (#14304)

* Emplace sample generated for customer issue on the side for future reference. (generate sas token and authenticate)
* Adjust stress test that was using push receive instead of pull.
* Add async version of non-session to session send failure test, make both cached to improve perf.

* Codegen for Azure Monitor (#14057)

* Codegen fro Azure Monitor

* codeowner

* commit 2

* Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md

* doc setings

* Update eng/.docsettings.yml

* Update eng/.docsettings.yml

* Update sdk/monitor/opentelemetry-exporter-azuremonitor/README.md

* Update eng/.docsettings.yml

* version

* oops

* comments

* Update sdk/monitor/opentelemetry-exporter-azuremonitor/LICENSE.txt

Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>

Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>

* [Storage][FileShare]Regenerate for delete leased snapshot (#14469)

* add repr to models (#14475)

* remove validations (#14476)

* Ma remove readonly assignments (#14478)

* Ensure azure-identity readme has exactly one H1 (#14480)

The docs publishing system disallows multiple H1 headings in a document.

* Sync eng/common directory with azure-sdk-tools for PR 1088 (#14482)

* Add pipeline configuration for cleaning up upstream branches

* Fix powershell naming

* Switch to use github API

* Use github API to delete branches

Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>

* enable live tests (#14467)

* Removed asynctestcase.py (#14444)

* testcase.py now uses AzureTestCase (#14443)

Co-authored-by: Krista Pratico <krpratic@microsoft.com>
Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: turalf <tural.ferhadov@gmail.com>
Co-authored-by: tural farhadov <tufarhad@microsoft.com>
Co-authored-by: KieranBrantnerMagee <kibrantn@microsoft.com>
Co-authored-by: Rakshith Bhyravabhotla <sabhyrav@microsoft.com>
Co-authored-by: Hector Hernandez <39923391+hectorhdzg@users.noreply.github.com>
Co-authored-by: Xiaoxi Fu <49707495+xiafu-msft@users.noreply.github.com>
Co-authored-by: Charles Lowell <chlowe@microsoft.com>
Co-authored-by: Chidozie Ononiwu <chononiw@microsoft.com>
Co-authored-by: Bradley D'Amato <53579156+bradleydamato@users.noreply.github.com>
@xiangyan99
Copy link
Member Author

/azp run python - tables - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mikeharder
Copy link
Member

Perf results show Stream matches Array after this PR:

  Stream (Mbps)   Array (Mbps)  
azure-core Pipeline stage_block Pipeline stage_block
1.8.2 5.93 5.88 287 302
PR 271 302 270 284

Test environment: #11044 (comment)

kasobol-msft
kasobol-msft previously approved these changes Nov 5, 2020
@xiangyan99
Copy link
Member Author

I tried it on Linux and did not see any perf impact.

@xiangyan99 xiangyan99 changed the title customize httpadapter to honor kwargs in send method Config the default blocksize to 32k for Python 3.7+ Nov 6, 2020
@xiangyan99 xiangyan99 merged commit c17c635 into master Nov 7, 2020
@xiangyan99 xiangyan99 deleted the core_customize_httpadapter branch November 7, 2020 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single request uploads of large "readable" data stream are slow (capped at ~8Mbps)
5 participants