Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed etag bug #13078

Merged
merged 8 commits into from
Aug 13, 2020
Merged

Fixed etag bug #13078

merged 8 commits into from
Aug 13, 2020

Conversation

tasherif-msft
Copy link
Contributor

@tasherif-msft tasherif-msft commented Aug 12, 2020

This PR resolves to #8490 intended to fix a small etag bug. Initially the etag variable was empty since it was not storing the appropriate response etag. Two additional unit tests were added.

xiafu-msft
xiafu-msft previously approved these changes Aug 12, 2020
@xiafu-msft
Copy link
Contributor

I just noticed we have the same issue in lease_async.py, can you also fix that in this pr ^_^ sorry that I didn't describe it in the github issue

xiafu-msft
xiafu-msft previously approved these changes Aug 12, 2020
@tasherif-msft
Copy link
Contributor Author

I just noticed we have the same issue in lease_async.py, can you also fix that in this pr ^_^ sorry that I didn't describe it in the github issue

Done :)

@tasherif-msft tasherif-msft merged commit 84fb33e into master Aug 13, 2020
@tasherif-msft tasherif-msft deleted the tamer-test-branch branch August 13, 2020 00:05
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Aug 17, 2020
…into get_certs_2016

* 'master' of https://github.com/Azure/azure-sdk-for-python: (26 commits)
  Type inference (Azure#12980)
  Add azure-ai-anomalydetector to error code 5 ignored list (Azure#13131)
  Handle missing model properties in Key Vault 2016-10-01 (Azure#13129)
  fix aad test so it runs locally (Azure#13127)
  Suppress errors in anomoly detector for now. (Azure#13141)
  Anomaly Detector V1, track2 generator (Azure#12931)
  [formrecognizer] Add `kind` to FormElement (Azure#13079)
  Regenerate code from connie's swagger change (Azure#12979)
  Update async (Azure#12978)
  Move get_access_conditions to _serialize.py (Azure#13105)
  [Storage][DataLake]Update Min Dependency (Azure#13108)
  Restore user authentication API from 1.4.0b7 (Azure#13070)
  [Storage][FileShare]ChangeLog update (Azure#13103)
  remove locale (Azure#13102)
  [Storage][Blob]ChangeLog Update (Azure#13081)
  Fixed etag bug (Azure#13078)
  [Storage][Blob]Fix live test and if tags bug (Azure#13054)
  [Storage][Blob][Batch]Support batch delete empty blob list (Azure#13029)
  [Storage][Blob][Bug]Support parsing blob url with '/' in blob name (Azure#12619)
  [formrecognizer] add api version enum (Azure#12888)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants